Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hermes cannot connect to gRPC server over IPv6 #4237

Closed
5 tasks
ljoss17 opened this issue Nov 5, 2024 · 0 comments · Fixed by #4231
Closed
5 tasks

Hermes cannot connect to gRPC server over IPv6 #4237

ljoss17 opened this issue Nov 5, 2024 · 0 comments · Fixed by #4231

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Nov 5, 2024

Description

Follow-up for the issue disabling TLS configuration for IPv6 endpoint, #4224.

TLS configuration would fail due to the brackets in the IPv6 endpoint when extracting the domain name. By using tonic method domain_name(), https://docs.rs/tonic/0.12.3/tonic/transport/channel/struct.ClientTlsConfig.html#method.domain_name, it is possible to specify the domain name so that the transport error: InvalidDnsNameError is avoided.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Nov 5, 2024
@ljoss17 ljoss17 mentioned this issue Nov 5, 2024
Merged
8 tasks
@romac romac changed the title Improve TLS configuration Hermes cannot connect to gRPC server over IPv6 Nov 5, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix gRPC over IPv6 informalsystems/hermes
1 participant
@ljoss17