Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC over IPv6 #4231

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix gRPC over IPv6 #4231

merged 3 commits into from
Nov 8, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Oct 31, 2024

Closes: #4237

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
    • If guide has been updated, tag GitHub user mircea-c
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 marked this pull request as ready for review November 5, 2024 10:40
@romac romac changed the title Improve TLS configuration to only configure if required Only enable TLS in tonic client for HTTPS endpoints Nov 5, 2024
@romac romac changed the title Only enable TLS in tonic client for HTTPS endpoints Fix gRPC over IPv6 Nov 5, 2024
@ljoss17 ljoss17 added this pull request to the merge queue Nov 7, 2024
@ljoss17 ljoss17 removed this pull request from the merge queue due to a manual request Nov 8, 2024
@ljoss17 ljoss17 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit c4153d6 Nov 8, 2024
29 checks passed
@ljoss17 ljoss17 deleted the luca_joss/improve-tls-configuration branch November 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermes cannot connect to gRPC server over IPv6
2 participants