Create and submit a transaction to SDK/TM chain #47

ancazamfir · 2020-04-07T18:01:11Z

Summary

Create and submit an IBC transaction to SDK/TM chain.

Problem Definition

relayer needs to submit transactions that include the IBC messages and packets.

Proposal

Evaluate https://github.com/iqlusioninc/crates/tree/develop/stdtx for submitting an IBC transaction. Could be for ClientCreate or ClientUpdate, or other.
Keystore doesn't have to be part of this if a workaround is found. We will deal with this in another issue.

For Admin Use

Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned

ebuchman · 2020-07-07T13:09:37Z

Let's start with a ConnOpenInit - https://github.com/cosmos/ics/tree/master/spec/ics-003-connection-semantics#opening-handshake

Should be able to run it from the relayer CLI

ebuchman · 2020-07-07T13:20:42Z

We should open a new issue listing the set of transactions so we can start knocking them off

ebuchman · 2020-07-19T17:11:22Z

Protobuf txs have not landed yet on the SDK so lets bump the milestone on this for now

tarcieri · 2020-09-02T18:40:55Z

ebuchman · 2020-09-20T14:06:55Z

This is effectively done in #242 but bringing it into the relayer-cli is now blocking on #243 or some other resolution of dependency hell.

* Initial implementation for the relayer tx command #206 * Adding initial logic to support signing #47 * Adding logic for auth tx * Implementing initial support to conn open init and tx #206 * Changes: - Implemented logic for tx raw connection open init - Logic to build the message only using protobuf types - Got some signing logic but not validated - Still needs lots of refactoring and cleaning * update signing code to use k256 * Ignore .idea * Refactoring the ConnOpenInit logic. Disabling the build and sign tx code #246 * Added logic for the conn init tx on relayer * Finished implementing MsgConnectionOpenInit. No signing implemented #246 Co-authored-by: Andy Nogueira <me@andynogueira.dev>

… to chain. #47

…ionality not implemented yet #47

* Implemented very basic keybase to store keys (memory store) * Logic to restore key (private/public) from mnemonic * Added keystore to the chain * Implemented working 'keys restore' command on the relayer

andynog · 2020-10-14T22:51:03Z

Got a basic keystore working. You can test against branch andy/tx-sign. Running the command below

 ./target/debug/relayer -c ./relayer-cli/tests/fixtures/two_chains.toml keys restore ibc0 test "mixture fatigue fold federal hour frequent atom seek apart diesel armed start lawn hello milk say steak peasant wonder inquiry vague mind reduce rib"

Should give the result (displays the address for now)

key restore result:  "55d4ae3492a831453fc273aff431fc76094e9b1c"

Next step is to use the private key to sign the message in the transaction.

…-4 not working (#47)

andynog · 2020-10-20T16:27:05Z

I believe the tx signing is working but getting a internal error testing against stargate-4 chains (running with go relayer dev-env script)

./target/debug/relayer -c ./relayer-cli/tests/fixtures/two_chains.toml tx raw conn-init ibc0 ibc1 ibczeroclient ibconeclient ibczeroconn ibconeconn
     Message ConnectionOpenInitOptions { src_client_id: ClientId("ibczeroclient"), dest_client_id: ClientId("ibconeclient"), src_connection_id: ConnectionId("ibczeroconn"), dest_connection_id: ConnectionId("ibconeconn"), src_chain_config: ChainConfig { id: chain::Id(ibc0), rpc_addr: Tcp { peer_id: None, host: "localhost", port: 26657 }, account_prefix: "cosmos", key_name: "testkey", store_prefix: "ibc", client_ids: ["cla1", "cla2"], gas: 200000, trusting_period: 1209600s }, dest_chain_config: ChainConfig { id: chain::Id(ibc1), rpc_addr: Tcp { peer_id: None, host: "localhost", port: 26557 }, account_prefix: "cosmos", key_name: "testkey", store_prefix: "ibc", client_ids: ["clb1"], gas: 200000, trusting_period: 1209600s } }
TxRAW "0a9f010a9c010a2d2f6962632e636f72652e636f6e6e656374696f6e2e76312e4d7367436f6e6e656374696f6e4f70656e496e6974126b0a0d6962637a65726f636c69656e74120b6962637a65726f636f6e6e1a1c0a0c6962636f6e65636c69656e74120a6962636f6e65636f6e6e1a002205312e302e302a283235454635364341373935313335453430393336384536444238313130463232413442453035433212500a4e0a460a1f2f636f736d6f732e63727970746f2e736563703235366b312e5075624b657912230a2103af916c8d01cfdb919cc875539c759b4adb210f324d716c7ab4e4d74d408cc9ac12040a0208011a400bb6dd5cca614c3217eb75203e1b5559ee0f88d4f01314ec90223f2e50c4e1bd62fe531a1fb9311c989e227330274602c27f142f43ac70a2627f4387962c6e6a"
Tx Error Response: Response { code: Err(1), data: Data([]), log: Log("internal"), hash: transaction::Hash(D2969C20DA35EBA7B1883F1679BD3AE272B07DCCF3559B02FF41511DDD325AB4) }
conn init failed, error:  tx error: Message transaction failure: failed to initialize open connection: RPC error: RPC error: internal

if I send the tx via broadcast_tx_sync directly also get the error

curl localhost:26657/broadcast_tx_sync?tx=0x0a9f010a9c010a2d2f6962632e636f72652e636f6e6e656374696f6e2e76312e4d7367436f6e6e656374696f6e4f70656e496e6974126b0a0d6962637a65726f636c69656e74120b6962637a65726f636f6e6e1a1c0a0c6962636f6e65636c69656e74120a6962636f6e65636f6e6e1a002205312e302e302a283235454635364341373935313335453430393336384536444238313130463232413442453035433212500a4e0a460a1f2f636f736d6f732e63727970746f2e736563703235366b312e5075624b657912230a2103af916c8d01cfdb919cc875539c759b4adb210f324d716c7ab4e4d74d408cc9ac12040a0208011a400bb6dd5cca614c3217eb75203e1b5559ee0f88d4f01314ec90223f2e50c4e1bd62fe531a1fb9311c989e227330274602c27f142f43ac70a2627f4387962c6e6a

{
  "jsonrpc": "2.0",
  "id": -1,
  "result": {
    "code": 1,
    "data": "",
    "log": "internal",
    "codespace": "undefined",
    "hash": "D2969C20DA35EBA7B1883F1679BD3AE272B07DCCF3559B02FF41511DDD325AB4"
  }

The error doesn't show up in the chains log so not sure where it's happening. Haven't been able to debug it directly on gaia or cosmos-sdk yet.

…#47)

…ing (#47)

…w conn-init command (#47)

andynog · 2020-10-23T20:49:06Z

The tx raw conn-init command works now. Signing the message is working and the gaia chain (stargate-4) accepts the transaction.

For now, I've added two parameters to the command

signer-key (-k) -> you specify a key file (name and location) that will be used as the signer. This key seed file has a mnemonic (seed phrase) that can be used to retrieve the private key (BIP-39)
account_sequence (-s) -> this is the account sequence value, basically every time a tx is committed by the account this number increases

Testing the transaction:

Start two chains using the dev-env script from the ovrclk/relayer (checkout stargate-4)
After you run the script, the Go relayer will create a data folder for the chains. Open the key seed file ./data/ibc1/key_seed.json for chain ibc-1 and look for the account value

{"name":"user","type":"local","address":"cosmos1tqzwwr5hrnq2ceg5fg52m720m50xpfy08at7l9","pubkey":"cosmospub1addwnpepq08wntxejcla5hd93stgudw02htdpa9vu5a2ds8xkvmgrkrrpwlj6sdhkz6","mnemonic":"[MNEMONIC WORDS"}

In order to find the account sequence run:

gaiad query account cosmospub1addwnpepq08wntxejcla5hd93stgudw02htdpa9vu5a2ds8xkvmgrkrrpwlj6sdhkz6 --home ./data/ibc1 --chain-id ibc1 --node tcp://localhost:26557

this will return the sequence number at the end. Make a note of that, you will need this number as an argument to the transaction command.

'@type': /cosmos.auth.v1beta1.BaseAccount
account_number: "0"
address: cosmos1tqzwwr5hrnq2ceg5fg52m720m50xpfy08at7l9
pub_key:
  '@type': /cosmos.crypto.secp256k1.PubKey
  key: A87prNmWP9pdpYwWjjXPVdbQ9KzlOqbA5rM2gdhjC78t
sequence: "12"

Run the transaction command. We will try to initialize an ibczeroconn2 connection

cargo run --bin relayer -- -c ./relayer-cli/tests/fixtures/two_chains.toml tx raw conn-init ibc0 ibc1 ibczeroclient ibconeclient ibczeroconn2 ibconeconn -s 12 -k key_seed.json

if you get an empty response it means the tx worked

conn init, result: []

Check if the connection was created on ibc-1 using the Golang relayer

rly query connections ibc1 | jq .

you should see an entry in the JSON file that points to the ibczeroconn2 connection with state STATE_INIT

{
      "id": "ibczeroconn21",
      "client_id": "ibczeroclient",
      "versions": [
        "\n\u00011\u0012\rORDER_ORDERED\u0012\u000fORDER_UNORDERED"
      ],
      "state": "STATE_INIT",
      "counterparty": {
        "client_id": "ibconeclient",
        "connection_id": "ibconeconn",
        "prefix": {
          "key_prefix": "aWJj"
        }
      }
    },

ancazamfir · 2020-10-27T12:56:17Z

Looks good. A few observations:

In order to find the account sequence run:
gaiad query account cosmospub1addwnpepq08wntxejcla5hd93stgudw02htdpa9vu5a2ds8xkvmgrkrrpwlj6sdhkz6 --home ./data/ibc1 --chain-id ibc1 --node tcp://localhost:26557

here we need to pass the address, cosmos1tqzwwr5hrnq2ceg5fg52m720m50xpfy08at7l9 in the example.

If we try to create the same connection twice we should get an error. You should call broadcast_tx_commit() in broadcast_tx(), this will return the Code (success or failure) and some Log and Data to show in case of failure.

Currently creating the connection second time returns:
conn init, result: []

Here are the current logs (removed some):

D[2020-10-27|13:31:55.968] Invalid tx                                   module=state code=2 log="\ngit.luolix.top/cosmos/cosmos-...(*localClient).DeliverTxAsync
failed to execute message; message index: 0: connection handshake open init failed: ibczeroconn4: connection already exists"

ancazamfir · 2020-10-27T13:03:21Z

With broadcast_tx_commit() it returns something like:

conn init, result:  TxResult { code: Err(2), data: None, log: Log("\ngit.luolix.top/cosmos/cosmos-sdk/x/ibc/core/03-connection/keeper.Keeper.ConnOpenInit\n\tgit.luolix.top/cosmos/cosmos-sdk@v0.40.0-rc0/x/ibc/core/03-connection/keeper/handshake.go:27\ngit.luolix.top/cosmos/cosmos-sdk/x/ibc/core/03-connection.HandleMsgConnectionOpenInit\n\tgit.luolix.top/cosmos/cosmos-sdk@v0.40.0-rc0/x/ibc/core/03-connection/handler.go:13\ngit.luolix.top/cosmos/cosmos-sdk/x/ibc/core.NewHandler.func1\n\tgit.luolix.top/cosmos/cosmos-sdk@v0.40.0-rc0/x/ibc/core/handler.go:36\ngit.luolix.top/cosmos/cosmos-sdk/baseapp.(*BaseApp).runMsgs\n\tgit.luolix.top/cosmos/cosmos-sdk@v0.40.0-rc0/baseapp/baseapp.go:692\ngit.luolix.top/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx\n\tgit.luolix.top/cosmos/cosmos-sdk@v0.40.0-rc0/baseapp/baseapp.go:653\ngit.luolix.top/cosmos/cosmos-sdk/baseapp.(*BaseApp).DeliverTx\n\tgit.luolix.top/cosmos/cosmos-sdk@v0.40.0-rc0/baseapp/abci.go:271\ngit.luolix.top/tendermint/tendermint/abci/client.(*localClient).DeliverTxAsync\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/abci/client/local_client.go:87\ngit.luolix.top/tendermint/tendermint/proxy.(*appConnConsensus).DeliverTxAsync\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/proxy/app_conn.go:85\ngit.luolix.top/tendermint/tendermint/state.execBlockOnProxyApp\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/state/execution.go:313\ngit.luolix.top/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/state/execution.go:138\ngit.luolix.top/tendermint/tendermint/consensus.(*State).finalizeCommit\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:1569\ngit.luolix.top/tendermint/tendermint/consensus.(*State).tryFinalizeCommit\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:1487\ngit.luolix.top/tendermint/tendermint/consensus.(*State).enterCommit.func1\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:1420\ngit.luolix.top/tendermint/tendermint/consensus.(*State).enterCommit\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:1459\ngit.luolix.top/tendermint/tendermint/consensus.(*State).addVote\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:2044\ngit.luolix.top/tendermint/tendermint/consensus.(*State).tryAddVote\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:1846\ngit.luolix.top/tendermint/tendermint/consensus.(*State).handleMsg\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:803\ngit.luolix.top/tendermint/tendermint/consensus.(*State).receiveRoutine\n\tgit.luolix.top/tendermint/tendermint@v0.34.0-rc4.0.20201005135527-d7d0ffea13c6/consensus/state.go:752\nfailed to execute message; message index: 0: connection handshake open init failed: ibczeroconn4: connection already exists") }

we will need to get a shorter explanation for that Err(2)

andynog · 2020-10-27T15:02:53Z

Thanks @ancazamfir I will look into those error cases for an existing connection.

* Initial implementation for tx sign * Adding logic to build the tx as part of the chain. Added broadcast tx to chain. #47 * Added keys restore command boileplate for abscissa. Restore key functionality not implemented yet #47 * Implemented changes to support tx signing (#47): * Implemented very basic keybase to store keys (memory store) * Logic to restore key (private/public) from mnemonic * Added keystore to the chain * Implemented working 'keys restore' command on the relayer * Refactoring keybase structure (#47) * Initial logic to send message (#47) * Got the logic to sign but MsgConnectionOpenInit test against stargate-4 not working (#47) * MsgConnectionOpenInit tx working logic! (#47) * Added option to tx raw conn-init to specify and read key file content (#47) * Logic to parse the key_seed.json file passed as tx raw parameter working (#47) * Added support to specify key file and account sequence for the tax raw conn-init command (#47) * Adding instructions on how to submit a transaction (#345) * Fixing format issues (#345) * Fixing tests (#345) * Update relayer/src/tx/client.rs I had this in place so I could test. OK to change it back Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update relayer/src/tx/connection.rs OK, didn't know where to get it from, thanks. Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

* Initial implementation for the relayer tx command informalsystems#206 * Adding initial logic to support signing informalsystems#47 * Adding logic for auth tx * Implementing initial support to conn open init and tx informalsystems#206 * Changes: - Implemented logic for tx raw connection open init - Logic to build the message only using protobuf types - Got some signing logic but not validated - Still needs lots of refactoring and cleaning * update signing code to use k256 * Ignore .idea * Refactoring the ConnOpenInit logic. Disabling the build and sign tx code informalsystems#246 * Added logic for the conn init tx on relayer * Finished implementing MsgConnectionOpenInit. No signing implemented informalsystems#246 Co-authored-by: Andy Nogueira <me@andynogueira.dev>

* Initial implementation for tx sign * Adding logic to build the tx as part of the chain. Added broadcast tx to chain. informalsystems#47 * Added keys restore command boileplate for abscissa. Restore key functionality not implemented yet informalsystems#47 * Implemented changes to support tx signing (informalsystems#47): * Implemented very basic keybase to store keys (memory store) * Logic to restore key (private/public) from mnemonic * Added keystore to the chain * Implemented working 'keys restore' command on the relayer * Refactoring keybase structure (informalsystems#47) * Initial logic to send message (informalsystems#47) * Got the logic to sign but MsgConnectionOpenInit test against stargate-4 not working (informalsystems#47) * MsgConnectionOpenInit tx working logic! (informalsystems#47) * Added option to tx raw conn-init to specify and read key file content (informalsystems#47) * Logic to parse the key_seed.json file passed as tx raw parameter working (informalsystems#47) * Added support to specify key file and account sequence for the tax raw conn-init command (informalsystems#47) * Adding instructions on how to submit a transaction (informalsystems#345) * Fixing format issues (informalsystems#345) * Fixing tests (informalsystems#345) * Update relayer/src/tx/client.rs I had this in place so I could test. OK to change it back Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update relayer/src/tx/connection.rs OK, didn't know where to get it from, thanks. Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

ancazamfir added I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic labels Apr 7, 2020

ancazamfir added this to the 0.4-4mo milestone Apr 7, 2020

ancazamfir assigned ebuchman Apr 7, 2020

ebuchman mentioned this issue Apr 11, 2020

WIP: StdTx #52

Closed

6 tasks

ancazamfir modified the milestones: 0.4-4mo, 0.6-6mo May 22, 2020

ancazamfir modified the milestones: 0.6-6mo, 0.8-8mo Jun 29, 2020

ancazamfir mentioned this issue Jun 29, 2020

High Level Goal - IBC Relayer #114

Closed

ebuchman modified the milestones: v0.0.4, v0.0.2 Jul 7, 2020

ebuchman modified the milestones: v0.0.2, v.0.0.3 Jul 19, 2020

ancazamfir modified the milestones: v.0.0.3, v0.0.4 Aug 28, 2020

andynog added a commit that referenced this issue Sep 8, 2020

Adding initial logic to support signing #47

1b7c32b

ebuchman mentioned this issue Sep 11, 2020

MVP Client Relayer: Periodic Client Updates #216

Closed

ebuchman mentioned this issue Sep 20, 2020

Signed Tx against latest Gaia #242

Closed

6 tasks

ebuchman mentioned this issue Sep 21, 2020

ConnOpenInit from the CLI #246

Merged

6 tasks

ancazamfir mentioned this issue Sep 23, 2020

Relayer CLIs for client messages #251

Merged

6 tasks

ancazamfir modified the milestones: v0.0.4, v0.0.5 Sep 30, 2020

andynog added a commit that referenced this issue Oct 7, 2020

Adding logic to build the tx as part of the chain. Added broadcast tx…

7ae66f2

… to chain. #47

andynog added a commit that referenced this issue Oct 13, 2020

Added keys restore command boileplate for abscissa. Restore key funct…

b8133a6

…ionality not implemented yet #47

andynog added a commit that referenced this issue Oct 20, 2020

Refactoring keybase structure (#47)

5b92633

andynog added a commit that referenced this issue Oct 20, 2020

Initial logic to send message (#47)

5fda69a

andynog added a commit that referenced this issue Oct 20, 2020

Got the logic to sign but MsgConnectionOpenInit test against stargate…

11acb90

…-4 not working (#47)

andynog added a commit that referenced this issue Oct 20, 2020

MsgConnectionOpenInit tx working logic! (#47)

a61629e

ancazamfir mentioned this issue Oct 21, 2020

Relayer CLIs for client update message #277

Closed

4 tasks

andynog added a commit that referenced this issue Oct 21, 2020

Added option to tx raw conn-init to specify and read key file content (…

c1e610a

…#47)

andynog added a commit that referenced this issue Oct 21, 2020

Logic to parse the key_seed.json file passed as tx raw parameter work…

71b63dd

…ing (#47)

andynog mentioned this issue Sep 29, 2022

Retrieve account sequence information from a chain using a GRPC client cosmos/ibc-proto-rs#18

Closed

5 tasks

andynog added a commit that referenced this issue Oct 23, 2020

Added support to specify key file and account sequence for the tax ra…

a75b1ec

…w conn-init command (#47)

andynog self-assigned this Oct 24, 2020

andynog changed the title ~~Investigate: create and submit transaction to SDK/TM chain~~ Create and submit a transaction to SDK/TM chain Oct 27, 2020

andynog mentioned this issue Oct 27, 2020

Transaction signing #345

Merged

5 tasks

ancazamfir closed this as completed in #345 Oct 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create and submit a transaction to SDK/TM chain #47

Create and submit a transaction to SDK/TM chain #47

ancazamfir commented Apr 7, 2020

ebuchman commented Jul 7, 2020 •

edited

Loading

ebuchman commented Jul 7, 2020

ebuchman commented Jul 19, 2020

tarcieri commented Sep 2, 2020

ebuchman commented Sep 20, 2020

andynog commented Oct 14, 2020 •

edited

Loading

andynog commented Oct 20, 2020

andynog commented Oct 23, 2020

ancazamfir commented Oct 27, 2020 •

edited

Loading

ancazamfir commented Oct 27, 2020

andynog commented Oct 27, 2020

Create and submit a transaction to SDK/TM chain #47

Create and submit a transaction to SDK/TM chain #47

Comments

ancazamfir commented Apr 7, 2020

Summary

Problem Definition

Proposal

For Admin Use

ebuchman commented Jul 7, 2020 • edited Loading

ebuchman commented Jul 7, 2020

ebuchman commented Jul 19, 2020

tarcieri commented Sep 2, 2020

ebuchman commented Sep 20, 2020

andynog commented Oct 14, 2020 • edited Loading

andynog commented Oct 20, 2020

andynog commented Oct 23, 2020

Testing the transaction:

ancazamfir commented Oct 27, 2020 • edited Loading

ancazamfir commented Oct 27, 2020

andynog commented Oct 27, 2020

ebuchman commented Jul 7, 2020 •

edited

Loading

andynog commented Oct 14, 2020 •

edited

Loading

ancazamfir commented Oct 27, 2020 •

edited

Loading