Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor of ForeignClient::build_update_client* methods #1059

Closed
wants to merge 1 commit into from

Conversation

romac
Copy link
Member

@romac romac commented Jun 7, 2021

Description

  • Improve legibility of loop condition when waiting for source chain to reach target_height
  • Use Option<Height>::None instead of Height::zero() in ForeignClient::build_update_client*` methods

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

))
})? < target_height
{
while latest_height()? < target_height {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ancazamfir Do we really want to wait here in a loop? Shouldn't this be handled via retries at the worker level?

@romac
Copy link
Member Author

romac commented Jun 11, 2021

Let's address this (#1009) all at once in another PR.

@romac romac closed this Jun 11, 2021
@romac romac deleted the romac/refactor-foreign-client-build-update branch September 15, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant