Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement query channel ends command #1130

Merged
merged 11 commits into from
Jul 5, 2021
Merged

Implement query channel ends command #1130

merged 11 commits into from
Jul 5, 2021

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Jun 28, 2021 •
edited by adizere
Loading

Closes: #1062

Description

In contrast to the the description & acceptance criteria in the linked issue, we ended up deciding on the following

  • CLI is `query channel ends CHAIN-ID PORT-ID CHAN-ID [-v/--verbose]
  • the output has the same structure as in the issue description, but slightly different names:
    • for -v option: ChannelEnds { ... }
    • without -v, default: ChannelEndsSummary { .. }

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@soareschen soareschen marked this pull request as ready for review June 28, 2021 12:39
@soareschen soareschen changed the title Implement query trace command Implement query channel ends command Jun 28, 2021
@romac romac mentioned this pull request Jun 28, 2021
Merged
9 tasks
adizere
adizere reviewed Jun 28, 2021
View reviewed changes
e2e/e2e/channel.py Show resolved Hide resolved
relayer-cli/src/commands/query/channel_ends.rs Outdated Show resolved Hide resolved
relayer-cli/src/commands/query/channel_ends.rs Show resolved Hide resolved
relayer-cli/src/commands/query/channel_ends.rs Outdated Show resolved Hide resolved
relayer-cli/src/commands/query/channel_ends.rs Show resolved Hide resolved
@adizere adizere self-assigned this Jul 2, 2021
@adizere adizere added E: gravity External: related to Gravity DEX needs guide update labels Jul 5, 2021
adizere
adizere approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go, cool stuff Soares, thank you!

@adizere adizere merged commit 95cfbfd into master Jul 5, 2021
@adizere adizere deleted the soares/query-trace-cli branch July 5, 2021 11:53
@hu55a1n1 hu55a1n1 mentioned this pull request Jul 28, 2021
Merged
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@soareschen @adizere
Implement query channel ends command (informalsystems#1130)
ed7187c 
* Initial draft to verify correct steps for query_trace

* Output result based on the specification

* Change command to `query channel ends`

* Fix incorrect chain query

* Add e2e test for query channel ends

* Address review feedback

* Introduce verbose opt. Removed summary. Renamed the output structs.

* Adjusted e2e tests

* Fix bug in e2e tests

* Changelog

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees

@adizere adizere

Labels
E: gravity External: related to Gravity DEX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New channel query to get channel, connection and client info in a single CLI
2 participants
@soareschen @adizere