Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abci::CheckTx equivalent for IBC module #1203

Merged
merged 5 commits into from
Jul 20, 2021
Merged

abci::CheckTx equivalent for IBC module #1203

merged 5 commits into from
Jul 20, 2021

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Jul 14, 2021 •
edited
Loading

Closes: cosmos/ibc-rs#78

Description

Exposes function to check if a transaction message is a valid IBC datagram.

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

adizere
adizere approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you Shoaib!

Could you please also add an entry in the changelog?

modules/src/ics26_routing/handler.rs Outdated Show resolved Hide resolved
@hu55a1n1
Copy link
Member Author

Could you please also add an entry in the changelog?

Thanks for reviewing @adizere! I just updated the CHANGELOG. 👍

@adizere adizere merged commit b61f677 into master Jul 20, 2021
@adizere adizere deleted the hu55a1n1/1194-abci-check-tx branch July 20, 2021 12:51
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@hu55a1n1 @adizere
abci::CheckTx equivalent for IBC module (informalsystems#1203)
9a70d59 
* Impl TryFrom<Any> for Ics26Envelope

* Add decode()

* Use decode() in deliver()

* Update CHANGELOG.md

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an ABCI CheckTx method equivalent for IBC
2 participants
@hu55a1n1 @adizere