Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pseudo root to MockConsensusState #1219

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Jul 21, 2021

Closes: cosmos/ibc-rs#75

Description

Added root to MockConsensusState

  • root should not be used, so it's just vec![0]

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac changed the title Fix/mock consensus state Add a pseudo root to MockConsensusState Jul 21, 2021
@romac romac merged commit d139f47 into informalsystems:master Jul 21, 2021
@yito88 yito88 deleted the fix/mock_consensus_state branch August 3, 2021 16:08
yito88 added a commit to heliaxdev/ibc-rs that referenced this pull request Aug 19, 2021
* fix MockConsensusState root

* cargo fmt

* update CHANGELOG
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* fix MockConsensusState root

* cargo fmt

* update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants