-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More explicit config error message #1240
Conversation
Can we instead catch the config error and print a more informative message? Maybe something like:
|
Good point! Done! 👍 |
Thanks! One last thing, can you please update the PR description with the new error message? LGTM otherwise :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a question, otherwise looks good!
Please consider updating the changelog also (we now use unclog
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Shoaib! I did one minor aesthetic change here d17d3e5. Approving and will let you do the merge if you agree with the changes I made.
* Be more explicit about config errors * Improve config error message * Update changelog * Changelog & added cfg path in the error message * Clippy fixes after rust update to rustc 1.54 Co-authored-by: Adi Seredinschi <adi@informal.systems>
Closes: #1021
Description
Modifies the configuration file parse error message, so an error that previously looked like so ->
LE @adizere -- Now looks like ->
For contributor use:
unclog
.docs/
) and code comments.Files changed
in the Github PR explorer.