Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Protobuf impl for ics03_connection::connection::Counterparty #1248

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Add Protobuf impl for ics03_connection::connection::Counterparty #1248

merged 2 commits into from
Jul 29, 2021

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Jul 29, 2021

Closes: #1247

Description

Added Protobuf for Counterparty.
Counterparty can be encoded/decoded by Protobuf.

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

romac
romac reviewed Jul 29, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@romac romac changed the title Add Protobuf for Counterparty Add Protobuf impl for ics03_connection::connection::Counterparty Jul 29, 2021
@romac romac merged commit ff6dfee into informalsystems:master Jul 29, 2021
adizere
adizere approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@yito88 yito88 deleted the yuji/add_counterparty_protobuf branch August 25, 2021 09:35
yito88 added a commit to heliaxdev/ibc-rs that referenced this pull request Aug 25, 2021
@yito88 @romac
Add Protobuf impl for ics03_connection::connection::Counterparty (i…
1366dc0 
…nformalsystems#1248)

* fix: add Protobuf for Counterparty

* Add .changelog entry

Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@yito88 @romac
Add Protobuf impl for ics03_connection::connection::Counterparty (i…
42f2c21 
…nformalsystems#1248)

* fix: add Protobuf for Counterparty

* Add .changelog entry

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@romac romac romac approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Protobuf for Counterparty
3 participants
@yito88 @romac @adizere