Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl ConsensusState for AnyConsensusState #1298

Merged
merged 2 commits into from
Aug 18, 2021
Merged

impl ConsensusState for AnyConsensusState #1298

merged 2 commits into from
Aug 18, 2021

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Aug 17, 2021

Closes: #1297

Description

Implement ConsensusState::root() and ConsensusState::validate_basic() for AnyConsensusState

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac merged commit 1adea5a into informalsystems:master Aug 18, 2021
@yito88 yito88 deleted the yuji/impl_consensus_state branch August 18, 2021 11:20
yito88 added a commit to heliaxdev/ibc-rs that referenced this pull request Aug 19, 2021
@yito88 @romac
Implement ConsensusState for AnyConsensusState (informalsystems#1298
0923154 
)

* impl ConsensusState for AnyConsensusState

* Add link to changelog entry

Co-authored-by: Romain Ruetschi <romain.ruetschi@gmail.com>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@yito88 @romac
Implement ConsensusState for AnyConsensusState (informalsystems#1298
bb59bcc 
)

* impl ConsensusState for AnyConsensusState

* Add link to changelog entry

Co-authored-by: Romain Ruetschi <romain.ruetschi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConsensusState for AnyConsensusState isn't implemented
2 participants
@yito88 @romac