ICS07: Add verification method for client update handler #1321

thanethomson · 2021-09-04T16:19:47Z

Closes cosmos/ibc-rs#71

Builds on and replaces #1252 with the following changes:

Attempts to make use of the Light Client verification functionality provided by the tendermint-light-client crate in implementing ICS07.
Updates all ibc-rs usage of tendermint-rs to make use of recent flex-error integration.

For contributor use:

Added a changelog entry, using unclog.
If applicable: Unit tests written, added test to CI.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (docs/) and code comments.
Re-reviewed Files changed in the Github PR explorer.

…formalsystems/ibc-rs into Check-Header-And-Update-State

Signed-off-by: Thane Thomson <connect@thanethomson.com>

modules/src/ics07_tendermint/client_def.rs

…rait Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>

…gnatures

ancazamfir

It looks good from my side for this PR. Will open a different issue to discuss and fix the client specific store.

…td and color-eyre

modules/src/ics02_client/error.rs

modules/src/ics02_client/handler/update_client.rs

modules/src/ics07_tendermint/client_def.rs

modules/src/ics07_tendermint/header.rs

modules/src/ics18_relayer/utils.rs

modules/src/mock/context.rs

romac

LGTM, thank you so much for all the work, @cezarad @thanethomson and @ancazamfir!

adizere

Great work team, thank you everyone for your patience and perseverence with this PR!

Note that I changed the "closing" issue associated to this PR. I think we can keep the changelog as it is.

adizere · 2021-10-14T08:55:50Z

modules/src/ics04_channel/handler/send_packet.rs

    use crate::timestamp::ZERO_DURATION;
+    use std::ops::Add;


One last concern: should we scrub this PR for std ?

It's in tests, which we will run with std, so it doesn't really matter whether we import from std or core, but in this case it wouldn't hurt to just import from core for consistency.

…tems#1321) * bla * on going * ongoing * on going * on going * timestamp default changed from none to now * failed ping pong - signs * Update context.rs * bla * blabla * fixed test client_update_ping_pong * fmt + clippy * Update context.rs * Update context.rs * remove comments * Update host.rs * Update to tendermint-rs v0.20.0 * Update changelog * Fix tendermint-rs version in changelog * Update predicates.rs * Update context.rs * tests * tendermint stuff in * Update Cargo.toml * clippy + fmt * moved predicates into ics07 header.rs * Adapted to latest TM changes * Fixed MockHeader test * Fmt & clippy * Removed irrelevant file * Bit more cleanup * fixed tests * upgraded to new error model * fmt * errors and timestamp changes * Fix error notation and formatting Signed-off-by: Thane Thomson <connect@thanethomson.com> * Upgrade to tendermint-rs master Signed-off-by: Thane Thomson <connect@thanethomson.com> * Use tendermint-rs from branch thane/ibc-1252 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Refactor ICS07 update handler to reuse light client verifier This commit makes use of the latest code from informalsystems/tendermint-rs#960 in order to reuse the light client's verification predicates instead of reimplementing them in the `ibc` crate. Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update Cargo.lock to address zeroize issue Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump tendermint-light-client dep to v0.22.0 for ibc module Signed-off-by: Thane Thomson <connect@thanethomson.com> * Refactor to accommodate new context API Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix missing import Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix imports Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix error check in test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Output debug version of error Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove test as per informalsystems#1321 (comment) Signed-off-by: Thane Thomson <connect@thanethomson.com> * Address comments from Adi Signed-off-by: Thane Thomson <connect@thanethomson.com> * Cosmetic tweaks Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add revision number check Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix broken test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Check incoming header height against chain ID version from client state Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add revision_number consistency check when deserializing header Signed-off-by: Thane Thomson <connect@thanethomson.com> * Clarify MismatchedRevisions error message Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entries Signed-off-by: Thane Thomson <connect@thanethomson.com> * Commented import no longer necessary Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add in-the-middle monotonicity checks Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix broken dep tree relating to Prometheus Signed-off-by: Thane Thomson <connect@thanethomson.com> * Move next/prev consensus state search functionality to ClientReader trait Signed-off-by: Thane Thomson <connect@thanethomson.com> * Move impl of prev/next to the specific implementation and simplify signatures * Disable `tendermint-light-client` default features, ie. RPC client, std and color-eyre * Apply suggestions from code review * Fix compilation * Cleanup BTreeMap import * Always show underlying reason in ics07_tendermint errors * Update modules/src/ics02_client/handler/update_client.rs * Fix compilation Co-authored-by: cezarad <cezara@informal.systems> Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: cezarad <9439384+cezarad@users.noreply.github.com> Co-authored-by: Adi Seredinschi <adi@informal.systems> Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>

* bla * on going * ongoing * on going * on going * timestamp default changed from none to now * failed ping pong - signs * Update context.rs * bla * blabla * fixed test client_update_ping_pong * fmt + clippy * Update context.rs * Update context.rs * remove comments * Update host.rs * Update to tendermint-rs v0.20.0 * Update changelog * Fix tendermint-rs version in changelog * Update predicates.rs * Update context.rs * tests * tendermint stuff in * Update Cargo.toml * clippy + fmt * moved predicates into ics07 header.rs * Adapted to latest TM changes * Fixed MockHeader test * Fmt & clippy * Removed irrelevant file * Bit more cleanup * fixed tests * upgraded to new error model * fmt * errors and timestamp changes * Fix error notation and formatting Signed-off-by: Thane Thomson <connect@thanethomson.com> * Upgrade to tendermint-rs master Signed-off-by: Thane Thomson <connect@thanethomson.com> * Use tendermint-rs from branch thane/ibc-1252 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Refactor ICS07 update handler to reuse light client verifier This commit makes use of the latest code from informalsystems/tendermint-rs#960 in order to reuse the light client's verification predicates instead of reimplementing them in the `ibc` crate. Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update Cargo.lock to address zeroize issue Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump tendermint-light-client dep to v0.22.0 for ibc module Signed-off-by: Thane Thomson <connect@thanethomson.com> * Refactor to accommodate new context API Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix missing import Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix imports Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix error check in test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Output debug version of error Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove test as per informalsystems/hermes#1321 (comment) Signed-off-by: Thane Thomson <connect@thanethomson.com> * Address comments from Adi Signed-off-by: Thane Thomson <connect@thanethomson.com> * Cosmetic tweaks Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add revision number check Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix broken test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Check incoming header height against chain ID version from client state Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add revision_number consistency check when deserializing header Signed-off-by: Thane Thomson <connect@thanethomson.com> * Clarify MismatchedRevisions error message Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entries Signed-off-by: Thane Thomson <connect@thanethomson.com> * Commented import no longer necessary Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add in-the-middle monotonicity checks Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix broken dep tree relating to Prometheus Signed-off-by: Thane Thomson <connect@thanethomson.com> * Move next/prev consensus state search functionality to ClientReader trait Signed-off-by: Thane Thomson <connect@thanethomson.com> * Move impl of prev/next to the specific implementation and simplify signatures * Disable `tendermint-light-client` default features, ie. RPC client, std and color-eyre * Apply suggestions from code review * Fix compilation * Cleanup BTreeMap import * Always show underlying reason in ics07_tendermint errors * Update modules/src/ics02_client/handler/update_client.rs * Fix compilation Co-authored-by: cezarad <cezara@informal.systems> Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: cezarad <9439384+cezarad@users.noreply.github.com> Co-authored-by: Adi Seredinschi <adi@informal.systems> Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>

cezarad and others added 30 commits June 8, 2021 07:59

bla

20c5ccf

on going

b5b9dcf

ongoing

dae68b1

on going

1b4ac9f

on going

58b5618

timestamp default changed from none to now

4fb5a0d

failed ping pong - signs

1deda2a

Update context.rs

cc5780a

bla

e63e5b3

blabla

2c91fe6

fixed test client_update_ping_pong

8d4ca79

fmt + clippy

87f538a

Update context.rs

3b470cc

Update context.rs

0bed49f

remove comments

437d345

Update host.rs

2d76e27

Update to tendermint-rs v0.20.0

3417872

Update changelog

33fe434

Fix tendermint-rs version in changelog

4b3e46c

Merge branch 'master' into Check-Header-And-Update-State

315dfc4

merged with #1126 Update to tendermint-rs v0.20.0

a225b75

Update predicates.rs

cff89a8

Merge branch 'master' into Check-Header-And-Update-State

be51b51

Update context.rs

4f47dcf

tests

bc72d52

Merge branch 'Check-Header-And-Update-State' of https://github.com/in…

06e44e9

…formalsystems/ibc-rs into Check-Header-And-Update-State

Merge branch 'Check-Header-And-Update-State' of https://github.com/in…

cdebb03

…formalsystems/ibc-rs into Check-Header-And-Update-State

tendermint stuff in

98f5cb0

Update Cargo.toml

e1a0f1b

clippy + fmt

fd7bc2e

Fix broken dep tree relating to Prometheus

b936f7f

Signed-off-by: Thane Thomson <connect@thanethomson.com>

thanethomson marked this pull request as ready for review October 5, 2021 20:05

thanethomson requested a review from romac as a code owner October 5, 2021 20:05

thanethomson requested review from adizere and ancazamfir October 5, 2021 20:05

ancazamfir reviewed Oct 6, 2021

View reviewed changes

modules/src/ics07_tendermint/client_def.rs Outdated Show resolved Hide resolved

ancazamfir reviewed Oct 6, 2021

View reviewed changes

modules/src/ics07_tendermint/client_def.rs Outdated Show resolved Hide resolved

thanethomson and others added 3 commits October 11, 2021 17:00

Move next/prev consensus state search functionality to ClientReader t…

b8f2506

…rait Signed-off-by: Thane Thomson <connect@thanethomson.com>

Merge latest changes from master and resolve conflict

5baef8c

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Move impl of prev/next to the specific implementation and simplify si…

1503839

…gnatures

ancazamfir self-requested a review October 12, 2021 09:40

ancazamfir approved these changes Oct 12, 2021

View reviewed changes

ancazamfir and others added 2 commits October 12, 2021 11:56

Merge branch 'master' into thane/1252-ics07

83e7b57

Disable tendermint-light-client default features, ie. RPC client, s…

ffa8672

…td and color-eyre

romac requested changes Oct 12, 2021

View reviewed changes

romac added 4 commits October 12, 2021 14:58

Apply suggestions from code review

5db8b62

Fix compilation

a795e2f

Cleanup BTreeMap import

4019c7b

Always show underlying reason in ics07_tendermint errors

c2ee39f

romac self-assigned this Oct 12, 2021

romac added 3 commits October 12, 2021 15:17

Update modules/src/ics02_client/handler/update_client.rs

7818a71

Fix compilation

c637821

Merge branch 'master' into thane/1252-ics07

b07e4eb

romac approved these changes Oct 14, 2021

View reviewed changes

adizere approved these changes Oct 14, 2021

View reviewed changes

adizere reviewed Oct 14, 2021

View reviewed changes

adizere merged commit fde0a96 into master Oct 19, 2021

adizere deleted the thane/1252-ics07 branch October 19, 2021 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ICS07: Add verification method for client update handler #1321

ICS07: Add verification method for client update handler #1321

thanethomson commented Sep 4, 2021 •

edited by adizere

Loading

ancazamfir left a comment

romac left a comment

adizere left a comment

adizere Oct 14, 2021

romac Oct 14, 2021

ICS07: Add verification method for client update handler #1321

ICS07: Add verification method for client update handler #1321

Conversation

thanethomson commented Sep 4, 2021 • edited by adizere Loading

ancazamfir left a comment

Choose a reason for hiding this comment

romac left a comment

Choose a reason for hiding this comment

adizere left a comment

Choose a reason for hiding this comment

adizere Oct 14, 2021

Choose a reason for hiding this comment

romac Oct 14, 2021

Choose a reason for hiding this comment

thanethomson commented Sep 4, 2021 •

edited by adizere

Loading