-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified packet worker to use stubborn strategy #1340
Conversation
use crate::worker::retry_strategy::{worker_stubborn_strategy, worker_default_strategy}; | ||
|
||
#[test] | ||
fn default_strategy() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is almost identical to this test
https://github.com/informalsystems/ibc-rs/blob/85446586daf6dba652271eef31dae29f35da86c2/relayer/src/util/retry.rs#L153
but I only realized after writing it.
I still found it useful to keep it around, for the purpose of understanding exactly the details of the strategy we use in practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌💯
* Modified packet worker to use stubborn strategy * Longer retry strategy, bigger backoff * Fmt & clippy * Made retry indefinite * Better comments * changelog
Closes: #1290
Description
The following describes worker behavior after this PR:
The rationale for this choice is as follows. I expect past a certain duration (I choose in this PR 6 hours), Hermes might as well give up, as there is little chance that the connection can become healthy again without operator intervention, but not sure if my intuition is appropriate.Unchanged behavior:
client worker
channel and connection workers
For contributor use:
unclog
.docs/
) and code comments.Files changed
in the Github PR explorer.