Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ibc::Timestamp::now to support no_std #1426

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Remove ibc::Timestamp::now to support no_std #1426

merged 1 commit into from
Oct 6, 2021

Conversation

soareschen
Copy link
Contributor

Part of #1158

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

adizere
adizere approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Soares!

@soareschen soareschen merged commit 82dd5b6 into master Oct 6, 2021
@soareschen soareschen deleted the soares/remove-now-from-ibc branch October 6, 2021 07:45
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@soareschen
Remove ibc::Timestamp::now to support no_std (informalsystems#1426)
90c5363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soareschen @adizere