Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default trusting period regression #1441

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix default trusting period regression #1441

merged 1 commit into from
Oct 11, 2021

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Oct 8, 2021 •
edited
Loading

Closes: #1133

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

ancazamfir
ancazamfir approved these changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ancazamfir ancazamfir merged commit 5836a5f into master Oct 11, 2021
@ancazamfir ancazamfir deleted the hu55a1n1/1392-def-trusting-period-regression branch October 11, 2021 06:36
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@hu55a1n1
Fix default trusting period regression (informalsystems#1441)
e6ae83d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir approved these changes

@adizere adizere Awaiting requested review from adizere

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config trusting-period, when not specified, should be set to 2/3rds of the unbonding period
2 participants
@hu55a1n1 @ancazamfir