Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frozen_height() to ClientState #1619

Merged
merged 7 commits into from
Dec 1, 2021
Merged

Add frozen_height() to ClientState #1619

merged 7 commits into from
Dec 1, 2021

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Nov 29, 2021

Closes: cosmos/ibc-rs#65

Description

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

hu55a1n1
hu55a1n1 requested changes Nov 29, 2021
View reviewed changes
Copy link
Member

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yito88! I added some suggestions, but the PR is looking great already. 👌

modules/src/clients/ics07_tendermint/client_state.rs Outdated Show resolved Hide resolved
modules/src/clients/ics07_tendermint/client_state.rs Outdated Show resolved Hide resolved
modules/src/clients/ics07_tendermint/client_state.rs Outdated Show resolved Hide resolved
modules/src/clients/ics07_tendermint/client_state.rs Outdated Show resolved Hide resolved
@hu55a1n1 hu55a1n1 mentioned this pull request Nov 29, 2021
Merged
5 tasks
@yito88
Copy link
Contributor Author

yito88 commented Nov 29, 2021

Thank you for revieiwing! Your suggestion makes sense.
I made the frozen_height private and fixed them.

hu55a1n1
hu55a1n1 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌷

adizere
adizere approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be nice to fix the nit that Shoaib raised wrt reporting in the changelog as 'breaking' instead of improvement. Thank you Yito88!

@romac romac merged commit 45ac6ca into informalsystems:master Dec 1, 2021
@soareschen soareschen mentioned this pull request Dec 3, 2021
Merged
6 tasks
@yito88 yito88 deleted the yuji/frozen_height branch December 15, 2021 13:14
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@yito88 @hu55a1n1
Add frozen_height() to ClientState (informalsystems#1619)
0f4b72f 
* add frozen_height() to ClientState

* fix for clippy

* make frozen_height private

* Remove AnyClientState::is_frozen() to reuse provided trait impl

* Modify .changelog entry

* rename to with_frozen_height

* Move changelog entry to breaking-changes section

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hu55a1n1 hu55a1n1 hu55a1n1 approved these changes

@romac romac romac left review comments

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yito88 @romac @adizere @hu55a1n1