Bump MSRV to 1.57 and instruct clippy to lint against this version #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently at 1.57.0 due to some recent lint-driven changes requiring the newest stable Rust.
mzabaluev
changed the title
Also in the guide.
As the process of updating to a new Rust version, especially when bumping the MSRV, requires many steps and some of them tend to get forgotten, make an issue template with a checklist of all the steps.
mzabaluev
added
the
I: infrastructure
romac
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Adding an issue template is a great idea! Thanks @mzabaluev :)
adizere
reviewed
Dec 9, 2021
| - [ ] Update the `rust-version` fields in all `Cargo.toml` files. | ||
| - [ ] Update the `msrv` field in `clippy.toml` and fix all lints reported by | ||
| `cargo clippy --all-features`. | ||
| - [ ] Update the MSRV shields in README files: |
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…nformalsystems#1660) * Bump rust-version to 1.57 in Cargo.toml * Add clippy.toml with the MSRV configuration Currently at 1.57.0 due to some recent lint-driven changes requiring the newest stable Rust. * Updated all mentions of MSRV to 1.57 Also in the guide. * Changelog entry for informalsystems#1660 * Add an issue template with Rust update checklist As the process of updating to a new Rust version, especially when bumping the MSRV, requires many steps and some of them tend to get forgotten, make an issue template with a checklist of all the steps. * Advise on fixing lints in rust-update template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1659
Description
Add a
clippy.tomlinstructing clippy to only emit lints that apply tothe MSRV declared there.
Update the
rust-versionfields inCargo.tomlto 1.57 which we in fact require after #1642.Also, add a GitHub issue template with a checklist detailing all the steps to make sure they don't get omitted in future Rust version bumps.
PR author checklist:
unclog.Added tests: integration (for Hermes) or unit/mock tests (for modules).docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.