ICS24 Path variants as types #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
20 tasks
romac
approved these changes
Jan 17, 2022
| @@ -28,44 +28,123 @@ const UPGRADED_CLIENT_STATE: &str = "upgradedClient"; | |||
| const UPGRADED_CLIENT_CONSENSUS_STATE: &str = "upgradedConsState"; | |||
|
|
|||
| /// The Path enum abstracts out the different sub-paths. | |||
| #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)] | |||
| #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, From, Display)] | |||
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Path variants as types * Use derive_more crate * Simplify Path usage * Minor refactoring * More cleanup * Add .changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: cosmos/ibc-rs#25
Description
ics24_host::Pathvariants as types - Since Rust doesn't treat enum variants as types, it might be a good idea to extract these variants as distinct types and use those types as the actual enum variants. This will allow us to enforce that certain functions accept only a certain type of path. eg.verify_client_consensus_state()should only accept aPath::ClientConsensusState.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.