Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize consensus metadata during client create #1763

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Initialize consensus metadata during client create #1763

merged 4 commits into from
Jan 14, 2022

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Jan 13, 2022 •
edited
Loading

Partially addresses: cosmos/ibc-rs#25

Description

Initialize ClientState metadata

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@hu55a1n1 hu55a1n1 marked this pull request as ready for review January 13, 2022 19:26
@romac romac merged commit 9541d3b into master Jan 14, 2022
@romac romac deleted the hu55a1n1/1696-init-consensus-metadata branch January 14, 2022 14:11
@hu55a1n1 hu55a1n1 mentioned this pull request Sep 28, 2022
Closed
20 tasks
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@hu55a1n1
Initialize consensus metadata during client create (informalsystems#1763
4d164dd 
)

* Initialize consensus metadata during client create

* Add .changelog entry

* Fix clippy warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hu55a1n1 @romac