Enable filtering by default and remove mode.packets.filter config option
#1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adizere
approved these changes
Jan 26, 2022
romac
added a commit
that referenced
this pull request
Jan 28, 2022
* Bump all crates to v0.11.0 and `ibc-proto` to v0.15.0 * Build changelog * Properly deal with error in `ChainScanner::counterparty_connection_state` * Add info on completions to the guide * Enable filtering by default and remove `mode.packets.filter` config option (#1819) * Enable filtering by default and remove `mode.packets.filter` config option * Add changelog entry * Remove `filter` option in various config files used on CI * Update comment in main config file * Update changelog for 1817 * Fix broken link in changelog Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
michaelfig
pushed a commit
to agoric-labs/ibc-rs
that referenced
this pull request
Feb 4, 2022
* Bump all crates to v0.11.0 and `ibc-proto` to v0.15.0 * Build changelog * Properly deal with error in `ChainScanner::counterparty_connection_state` * Add info on completions to the guide * Enable filtering by default and remove `mode.packets.filter` config option (informalsystems#1819) * Enable filtering by default and remove `mode.packets.filter` config option * Add changelog entry * Remove `filter` option in various config files used on CI * Update comment in main config file * Update changelog for 1817 * Fix broken link in changelog Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Bump all crates to v0.11.0 and `ibc-proto` to v0.15.0 * Build changelog * Properly deal with error in `ChainScanner::counterparty_connection_state` * Add info on completions to the guide * Enable filtering by default and remove `mode.packets.filter` config option (informalsystems#1819) * Enable filtering by default and remove `mode.packets.filter` config option * Add changelog entry * Remove `filter` option in various config files used on CI * Update comment in main config file * Update changelog for 1817 * Fix broken link in changelog Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1817
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.