Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Capability{Reader,Keeper} traits #1826

Merged
merged 14 commits into from
Feb 9, 2022
Merged

Implement Capability{Reader,Keeper} traits #1826

merged 14 commits into from
Feb 9, 2022

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Jan 31, 2022 •
edited
Loading

Closes: cosmos/ibc-rs#58

  • Add CapabilityReader/Keeper traits
  • Fix isolated crate build
  • Remove ics26::dispatch ctx clone.
  • Derive Display for ics24::Path variant types.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@hu55a1n1 hu55a1n1 marked this pull request as ready for review February 2, 2022 14:10
@romac romac changed the title Implement Capability{Reader,Keeper} traits Implement Capability{Reader,Keeper} traits Feb 3, 2022
romac
romac requested changes Feb 8, 2022
View reviewed changes
modules/src/core/ics05_port/context.rs Outdated Show resolved Hide resolved
modules/src/core/ics05_port/context.rs Outdated Show resolved Hide resolved
modules/src/core/ics05_port/error.rs Outdated Show resolved Hide resolved
modules/src/core/ics05_port/error.rs Outdated Show resolved Hide resolved
romac
romac approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just needs a merge from master and we're good to go :)

@hu55a1n1 hu55a1n1 merged commit 0a952b2 into master Feb 9, 2022
@hu55a1n1 hu55a1n1 deleted the hu55a1n1/1769-cap-reader-keeper branch February 9, 2022 16:30
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@hu55a1n1 @romac
Implement Capability{Reader,Keeper} traits (informalsystems#1826)
658b3d5 
* Impl Display for Path types instead of enum variants

* Fix no-std build

* Add CapabilityKeeper, CapabilityReader and PortKeeper traits

* Remove Ics26Context clone

* Fix build

* Add unclog entry

* Add comments

* Update Mock impl

* Apply suggestions from code review

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Use .to_string() instead of format!()

* Add CapabilityName newtype

* Simplify mock PortReader impl

* Fix validation check for CapabilityName

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Capability{Reader,Keeper} traits
2 participants
@hu55a1n1 @romac