Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching layer in Hermes #1932

Merged
merged 23 commits into from
Mar 2, 2022
Merged

Add caching layer in Hermes #1932

merged 23 commits into from
Mar 2, 2022

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Mar 2, 2022

Closes: #1908

Description

Cache results of some ABCI queries that are used a lot.

Created in the hackaton 02.03.2022 in the Lausanne office.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@adizere adizere marked this pull request as ready for review March 2, 2022 16:49
@adizere adizere merged commit 1ca7252 into master Mar 2, 2022
@adizere adizere deleted the hack/cache branch March 2, 2022 17:57
@adizere adizere changed the title Cache query result Add caching layer in Hermes Mar 3, 2022
@adizere adizere mentioned this pull request Mar 3, 2022
6 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Introduce CachingChainHandle

* Use CachingProdChainHandle in integration tests

* Global cache sketch via the registry

* First draft of caching connection data

* Draft caching for ChannelEnd states

* Hack: cache latest height

* Cache client state

* Consts for cache TTL durations

* Only cache queries with latest height

* Minor fixes

* Use PortChannelId in Cache

* Remove an unused function

* Make CacheKey private again

* Separate out probing and caching chain handle wrappers

* changelog

* Remove cfg for inc_metric

* Team sync PR review comms

* Decrease TTL for latest height cache

* Fix errors

* Round 2 reviews

* Rename round 3

Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermes caching layer MVP
4 participants