Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out test framework from integration tests #1961

Merged
merged 4 commits into from
Mar 15, 2022

Conversation

soareschen
Copy link
Contributor

Description

This PR introduces a new ibc-test-framework that is split out from ibc-integration-test. This allows the test framework to be reused in other tests in the future without having to also import the current test suite that specifically target ibc-rs.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@soareschen soareschen merged commit bb6b7a5 into master Mar 15, 2022
@soareschen soareschen deleted the soares/test-framework-crate branch March 15, 2022 13:03
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Split out test framework from integration tests

* Fix integration test not triggering

* Add changelog

* Fix doc tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants