Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust to 1.60.0 #2081

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Upgrade Rust to 1.60.0 #2081

merged 2 commits into from
Apr 11, 2022

Conversation

soareschen
Copy link
Contributor

Description

Updating Rust to v1.60.0 so that the result on CI matches the result on local machine.

PSA: When updating the code base with this new rust-toolchain.toml file, make sure that you stop Rust Analyzer and the running editor first before pulling the new change. Otherwise you may encounter error message like:

the 'cargo' binary, normally provided by the 'cargo' component, is not applicable to the '1.60.0-x86_64-unknown-linux-gnu' toolchain

To fix that, you have to first quit Rust Analyzer and run the following to re-add the component in Rustup:

rustup component remove cargo
rustup component add cargo

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@mzabaluev
Copy link
Contributor

Another PSA: whenever you want to update the MSRV (which this PR does not do), be sure to follow the checklist in the corresponding issue template

@soareschen
Copy link
Contributor Author

Another PSA: whenever you want to update the MSRV (which this PR does not do), be sure to follow the checklist in the corresponding issue template

Updated the Rust MSRV as well.

@romac
Copy link
Member

romac commented Apr 8, 2022

Let's wait until Monday to merge this to give upstream projects a chance to catch up as well.

@romac romac merged commit a3a64a7 into master Apr 11, 2022
@romac romac deleted the soares/rust-1.60 branch April 11, 2022 11:40
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants