Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for Gaia v5 in favor of Gaia v7 #2092

Merged
merged 17 commits into from
May 6, 2022

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented Apr 12, 2022

Closes: #1986

Description

Per the acceptance criteria listed in #1986:

  • Remove legacy option from the chain-upgrade CLI
  • Remove all the references to gaia-v4 and upgrade the CI test suite to use gaia-v7

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac
Copy link
Member

romac commented Apr 25, 2022

Shouldn't the test-end-to-end-current-gaia be updated to Gaia v6 and test-end-to-end-future-gaia be updated to v7?

We should probably also remove the v5 integration-test.

@romac romac changed the title Deprecate support for Gaia v4 in favor of Gaia v7 Deprecate support for Gaia v5 in favor of Gaia v7 Apr 25, 2022
@adizere
Copy link
Member

adizere commented Apr 26, 2022

Shouldn't the test-end-to-end-current-gaia be updated to Gaia v6 and test-end-to-end-future-gaia be updated to v7?

This makes sense. Alternatively, with Sean we discussed the following scheme:

Using the scheme "legacy/current" is more appropriate than "current/future" because v7 is already live. We will rarely be ahead of the release cycle (hence no need for "future").

@romac
Copy link
Member

romac commented Apr 26, 2022

Sounds good!

@seanchen1991
Copy link
Contributor Author

seanchen1991 commented Apr 26, 2022

I ran into an issue when running the build-ibc-chains.sh script on OSX. The

RUN apk add --no-cache $PACKAGES && make tools && make install

step seems quite brittle. @andynog also ran the script on Fedora and encountered an issue on the same step.

@soareschen suggested that perhaps building the new Gaia versions can be made less error-prone by using nix shell in the gaia.Dockerfile.

@adizere adizere self-assigned this Apr 29, 2022
@adizere adizere marked this pull request as ready for review May 6, 2022 11:09
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean & Mikhail!

@adizere adizere merged commit a3173f6 into informalsystems:master May 6, 2022
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Remove `--legacy` flag from `upgrade-chain` command

* Remove options related to `legacy` flag

* Remove Proposal::Legacy variant

* Update GAIA_BRANCH parameter

* Rename docker-compose files and update README accordingly

* Update GAIA_BRANCH parameter to v7.0.0 and update README

* Have GAIA_BRANCH point to v7.0.1

* Update gaia versions in docker-compose yml files

* Debug session w/ Sean

* Remove problematic line from gaia.Dockerfile

* Commit generated gaia v7 files

* Update github workflows and CI README

* Remove a bogus argument to docker build

* generated new files, push to dockerhub, update reamdes

* changelog

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Co-authored-by: Adi Seredinschi <adi@informal.systems>
Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate support for Gaia v4 and replace with Gaia v7 on CI
4 participants