Added gm fix conforming to keys add breaking changes
#2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
adizere
commented
Jun 2, 2022
Comment on lines
-998
to
+999
| gas_price = { price = 0.001, denom = '${DENOM}' } | ||
| max_gas = 1000000 | ||
| gas_price = { price = 0.01, denom = '${DENOM}' } | ||
| max_gas = 10000000 |
There was a problem hiding this comment.
Note to reviewers: this change is unrelated to bug #2262.
It's just a parameter change so Hermes can submit bigger transactions by default (allows bigger gas usage).
romac
approved these changes
Jun 3, 2022
|
There is also the script |
Please feel free to do it, thank you! |
adizere
changed the title
gm fix conforming to keys add breaking changes
adizere
commented
Jun 3, 2022
| @@ -64,13 +64,13 @@ cargo build -q --locked | |||
| # add the key seeds to the keyring of each chain | |||
| echo "Importing keys..." | |||
| cargo run -q --bin hermes -- -c "$CONFIG_FILE" keys add "$CHAIN_0_ID" -f "$GAIA_DATA/$CHAIN_0_ID/user_seed.json" | |||
| cargo run -q --bin hermes -- -c "$CONFIG_FILE" keys add "$CHAIN_0_ID" -f "$GAIA_DATA/$CHAIN_0_ID/user2_seed.json" -n user2 | |||
There was a problem hiding this comment.
Great catch, thank you for fixing Luca!
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…tems#2263) * Added fix cf. to breaking changes in informalsystems#2251 * Bumped version * Adjusted to higher default gas params to make testing easier * Updated init-hermes script to use new keyname flag for 'keys add' command Co-authored-by: Luca Joss <luca@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2262
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.