Introduce HeightQuery to be used in queries
#2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
changed the title
Height::zero
Co-authored-by: Adi Seredinschi <adi@informal.systems>
plafer
changed the title
Height::zeroHeightQuery to be used in queries
|
Reduced the scope of the PR in an effort to reduce the size of PRs, limiting it to using the new Will be ready for review soon after #2304 is merged. |
plafer
requested review from
adizere,
romac,
seanchen1991,
ancazamfir,
mzabaluev and
soareschen
as code owners
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Change many queries to use HeightQuery * use appropriate query height in upgrade * changelog * use application height in build_update_client * don't wait for target height * better error message * Update relayer/src/foreign_client.rs Co-authored-by: Adi Seredinschi <adi@informal.systems> * docstrings and var name change * use ibc::Height::decrement * add warning * query_latest_height call once * Remove Eq/PartialEq from request structs * height -> upgrade_height * HeightQuery in QueryHostConsensusStateRequest * Height -> TmHeight Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2313
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.