Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Height::zero() from relayer #2329

Merged
merged 9 commits into from
Jun 24, 2022
Merged

Remove Height::zero() from relayer #2329

merged 9 commits into from
Jun 24, 2022

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jun 21, 2022 •
edited
Loading

Closes: #2328

Note: I thought it best to only add the changelog entry in the subsequent PR which completely removes Height::zero().

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@plafer plafer marked this pull request as ready for review June 22, 2022 20:11
@adizere adizere self-assigned this Jun 23, 2022
ancazamfir
ancazamfir approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @plafer !

adizere
adizere approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look, it's a joy to read this code.

@adizere adizere merged commit 257740a into master Jun 24, 2022
@adizere adizere deleted the plafer/2328-height-zero-relayer branch June 24, 2022 08:58
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@plafer @adizere
Remove Height::zero() from relayer (informalsystems#2329)
f13126c 
* Cargo lock

* HeightQuery -> QueryHeight

* move query types to relayer's requests file

* QueryClientEventRequest uses QueryHeight

* QueryPacketEventDataRequest uses QueryHeight

* Make trusted_height an Option<Height>

* target_height: use QueryHeight

* MsgTransfer uses Option<Height> for timeout_height field

* Import nit

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir ancazamfir approved these changes

@romac romac Awaiting requested review from romac

@seanchen1991 seanchen1991 Awaiting requested review from seanchen1991

@mzabaluev mzabaluev Awaiting requested review from mzabaluev

@soareschen soareschen Awaiting requested review from soareschen

@hu55a1n1 hu55a1n1 Awaiting requested review from hu55a1n1

Assignees

@adizere adizere

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of Height::zero() in relayer
3 participants
@plafer @adizere @ancazamfir