Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the concept of a "zero Height" #2346

Merged
merged 46 commits into from
Jul 4, 2022
Merged

Remove the concept of a "zero Height" #2346

merged 46 commits into from
Jul 4, 2022

Commits on Jun 24, 2022

  1. From<Height> for String fix

    @plafer
    plafer committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    d20ac5b View commit details
    Browse the repository at this point in the history

  2. Use Option<Height> instead of Height::zero for consensus_height

    @plafer
    plafer committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    aae757b View commit details
    Browse the repository at this point in the history

  3. recv_packet still had Height::zero() in events

    @plafer
    plafer committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    00957d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. TryFrom<RawHeight> for Height

    @plafer
    plafer committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    047727f View commit details
    Browse the repository at this point in the history

  2. pre height parse changes

    @plafer
    plafer committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    444f2c3 View commit details
    Browse the repository at this point in the history

  3. Packet.timeout_height is now an Option<Height>

    @plafer
    plafer committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    0b19d58 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. rustdoc

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    bf6192d View commit details
    Browse the repository at this point in the history

  2. Remove Height::with_revision_height

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    2e47253 View commit details
    Browse the repository at this point in the history

  3. commit pre-modifying cli

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    56378b5 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into plafer/1009-height-… 

    …zero-complete
    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    0816c29 View commit details
    Browse the repository at this point in the history

  5. Finish Height::new() returns Result

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    036da49 View commit details
    Browse the repository at this point in the history

  6. remove Height::is_zero()

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    362dab3 View commit details
    Browse the repository at this point in the history

  7. Remove Height::zero()

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    d1f9e45 View commit details
    Browse the repository at this point in the history

  8. Remove Height::default()

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    52941d4 View commit details
    Browse the repository at this point in the history

  9. Height fields accessors

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    7507bfd View commit details
    Browse the repository at this point in the history

  10. use revision_height accessor

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    2004958 View commit details
    Browse the repository at this point in the history

  11. use revision_number accessor

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c2418c1 View commit details
    Browse the repository at this point in the history

  12. make Height fields private (WIP)

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    97fd832 View commit details
    Browse the repository at this point in the history

  13. compile error fixes

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    fca5c9e View commit details
    Browse the repository at this point in the history

  14. FIXME in transfer.rs addressed

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    7730de8 View commit details
    Browse the repository at this point in the history

  15. Use existing constants instead of hardcoded strings

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    b10a703 View commit details
    Browse the repository at this point in the history

  16. changelog

    @plafer
    plafer committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    1bc18b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. TimeoutHeight newtype

    @plafer
    plafer committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    5660a99 View commit details
    Browse the repository at this point in the history

  2. Use TimeoutHeight everywhere

    @plafer
    plafer committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    69234fb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into plafer/1009-height-… 

    …zero-complete
    @plafer
    plafer committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    e2bfa1f View commit details
    Browse the repository at this point in the history

  4. Fixes after merging with master

    @plafer
    plafer committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bb8192e View commit details
    Browse the repository at this point in the history

  5. has_expired() fix

    @plafer
    plafer committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    78eb9f1 View commit details
    Browse the repository at this point in the history

  6. doc url

    @plafer
    plafer committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    1178a2e View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. fix send_packet test

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    a1bd379 View commit details
    Browse the repository at this point in the history

  2. Remove timeout_height == 0 && timestamp == 0 check

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6e2cf23 View commit details
    Browse the repository at this point in the history

  3. Remove has_timeout()

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    87cbfed View commit details
    Browse the repository at this point in the history

  4. Change TimeoutHeight impl

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    95eb992 View commit details
    Browse the repository at this point in the history

  5. docstrings

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    b3d4248 View commit details
    Browse the repository at this point in the history

  6. tests fix

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6ed145b View commit details
    Browse the repository at this point in the history

  7. fix history manipulation test

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    a2ec5aa View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into plafer/1009-height-… 

    …zero-complete
    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    c958e62 View commit details
    Browse the repository at this point in the history

  9. transfer test: no timeout

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    8eff6d6 View commit details
    Browse the repository at this point in the history

  10. msgtransfer test

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    62cad52 View commit details
    Browse the repository at this point in the history

  11. packet no timeout or timestamp test

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    0d3d2f2 View commit details
    Browse the repository at this point in the history

  12. send_packet timeout height equal destination chain height

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    c1a2a86 View commit details
    Browse the repository at this point in the history

  13. send_packet test with timeout = height - 1

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    a8a958c View commit details
    Browse the repository at this point in the history

  14. test invalid timeout height

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    c0fafdb View commit details
    Browse the repository at this point in the history

  15. fix docstring

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    4a9dca7 View commit details
    Browse the repository at this point in the history

  16. clippy

    @plafer
    plafer committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    6a58582 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Fix clippy warnings introduced in Rust 1.62

    @romac
    romac committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    e262c3c View commit details
    Browse the repository at this point in the history

  2. Fix serialization of TimeoutHeight to match the format used by `Hei… 

    …ght`
    @romac
    romac committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    f5c3f67 View commit details
    Browse the repository at this point in the history