Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ChannelId representation to String #2361

Merged
merged 13 commits into from
Jul 4, 2022
Merged

Change ChannelId representation to String #2361

merged 13 commits into from
Jul 4, 2022

Commits on Jul 1, 2022

  1. Change ChannelId representation to String 

    ICS 024 does not restrict channel IDs to the "channel-{N}" format.
    @mzabaluev
    mzabaluev committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    06c1826 View commit details
    Browse the repository at this point in the history

  2. More clone calls for ChannelId, clippy fixes

    @mzabaluev
    mzabaluev committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    be95a53 View commit details
    Browse the repository at this point in the history

  3. fmt fix

    @mzabaluev
    mzabaluev committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    87cee8e View commit details
    Browse the repository at this point in the history

  4. Changelog entry for #2361

    @mzabaluev
    mzabaluev committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    5034794 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into mikhail/string-channel-id

    @mzabaluev
    mzabaluev committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    d4d00c4 View commit details
    Browse the repository at this point in the history

  6. ChannelId formatting fixes 

    - Create valid IDs with ChannelId::new (could be under valid length).
- Format as the inner string with Display.
- Derive Debug, no need for a manual definition, which printed it wrong.
    @mzabaluev
    mzabaluev committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    4381dd1 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Relax the channel identifier valid length 

    Contrary to what is still documented in ICS 024,
the minimum length accepted by ibc-go is 8 characters:
https://github.com/cosmos/ibc-go/blob/e04964912c266bab923253c48d72cc8ec8b38f5e/modules/core/24-host/validate.go#L76-L81
    @mzabaluev
    mzabaluev committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    473a96d View commit details
    Browse the repository at this point in the history

  2. Add unit tests for validate_channel_identifier

    @mzabaluev
    mzabaluev committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    4ac3bb4 View commit details
    Browse the repository at this point in the history

  3. Tweak test data for excessively long channel IDs 

    The length limit is now 64 characters in accordance with ICS 024
and ibc-go, but longer than previous code admitted.
    @mzabaluev
    mzabaluev committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    849f401 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into mikhail/string-channel-id

    @mzabaluev
    mzabaluev committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    945438c View commit details
    Browse the repository at this point in the history

  5. Improve changelog entries for #2361 

    - File under the modules component.
- Add an entry to bug-fixes mentioning the corrected enforcement
  of the length limit on channel IDs.
    @mzabaluev
    mzabaluev committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    33838f6 View commit details
    Browse the repository at this point in the history

  6. Fix outdated comment

    @romac
    romac committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    72e46f2 View commit details