Removed TryFromRaw, implemented DomainType where needed #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
Sep 24, 2020
| @@ -47,14 +47,18 @@ fn simd_chain() -> CosmosSDKChain { | |||
| #[test] | |||
| #[ignore] | |||
| fn query_connection_id() { | |||
| /* the current informaldev/simd image has an incompatible (old?) protobuf implementation | |||
There was a problem hiding this comment.
What’s the path forward for re-enabling this test? Do we just need to wait for the image to be updated to the new protobuf implementation? What does that mean actually? New protobuf message descriptors?
There was a problem hiding this comment.
Yes, we need a new docker image with an updated simd application. The protobuf message was updated in the SDK and an extra field added. We have more recent protobuf structs than the simd. (The simd is from the times of game-of-zones phase 1 when a bunch of the protobuf looked different.)
12 tasks
Co-authored-by: Adi Seredinschi <adi@informal.systems>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…ems#252) * Removed TryFromRaw, implemented DomainType where needed * Update modules/src/ics03_connection/connection.rs Co-authored-by: Adi Seredinschi <adi@informal.systems> Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #249
Description
TryFromRaw was removed and replaced with the DomainType trait. Tests were updated and I found that the ConnectionID integration test fails because the simd application protobuf is outdated. (Commented out for now.)
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer