Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 012: Handlers validation and execution separation #2631

Closed
wants to merge 25 commits into from
Closed

ADR 012: Handlers validation and execution separation #2631

wants to merge 25 commits into from

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Sep 9, 2022 •
edited
Loading

Closes: cosmos/ibc-rs#10

Rendered view

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

hu55a1n1
hu55a1n1 reviewed Sep 12, 2022
View reviewed changes
docs/architecture/adr-012-handlers-redesign.md Outdated

#### Store

Hosts are expected to implement the `IbcStore` trait that provides access to all IBC paths as defined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we currently do not differentiate between provable and private stores since ibc::core::ics24_host::path::Path doesn't differentiate between provable and private paths.

@plafer plafer marked this pull request as ready for review September 19, 2022 23:39
hu55a1n1
hu55a1n1 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer
Copy link
Contributor Author

plafer commented Sep 21, 2022

Waiting for external feedback before merging

@romac romac marked this pull request as draft September 22, 2022 12:06
seanchen1991
seanchen1991 reviewed Sep 22, 2022
View reviewed changes
docs/architecture/adr-012-handlers-redesign.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-handlers-redesign.md Show resolved Hide resolved
docs/architecture/adr-012-handlers-redesign.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-handlers-redesign.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-handlers-redesign.md Outdated Show resolved Hide resolved
docs/architecture/adr-012-handlers-redesign.md Outdated Show resolved Hide resolved
@romac
Copy link
Member

romac commented Oct 4, 2022

Shall we move this to cosmos/ibc-rs?

@hu55a1n1 hu55a1n1 mentioned this pull request Oct 6, 2022
Merged
7 tasks
@hu55a1n1
Copy link
Member

hu55a1n1 commented Oct 6, 2022

Moved to cosmos/ibc-rs#153

@hu55a1n1 hu55a1n1 closed this Oct 6, 2022
@romac romac deleted the plafer/adr12-handlers-redesign branch November 8, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 left review comments

@hu55a1n1 hu55a1n1 hu55a1n1 approved these changes

Assignees

@hu55a1n1 hu55a1n1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADR for redesigning the modules' API
4 participants
@plafer @romac @hu55a1n1 @seanchen1991