Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs the packets involved in the clear packets CLI flow #2653

Merged
merged 12 commits into from
Sep 21, 2022
Merged

Logs the packets involved in the clear packets CLI flow #2653

merged 12 commits into from
Sep 21, 2022

Conversation

AlianBenabdallah
Copy link
Contributor

@AlianBenabdallah AlianBenabdallah commented Sep 20, 2022 •
edited by romac
Loading

Closes: #2623

Description

This PR logs the packets involved in the clear packets CLI flow as explained in this comment.

It also generalizes PrettyVec into PrettySlice.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac enabled auto-merge (squash) September 21, 2022 12:40
@romac romac merged commit 286a216 into master Sep 21, 2022
@romac romac deleted the ali/log_sequence_nbr branch September 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider logging the packets involved in the clear packets CLI flow
2 participants
@AlianBenabdallah @romac