Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proto crates from the repository #2667

Merged
merged 22 commits into from
Oct 4, 2022
Merged

Remove proto crates from the repository #2667

merged 22 commits into from
Oct 4, 2022

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Sep 22, 2022

Partially addresses: #2639
Closes: #1579

Description

This PR is part of the repo-split work and deletes the proto crates (ibc-proto and ibc-proto-compiler) from the workspace and modifies other crates to depend on the crates.io versions of the proto crate directly. It also attempts to delete all references to the proto crates in the repository (docs, GitHub workflows, etc.).

The PR additionally fixes some GitHub workflow paths that were incorrect.

Note: Since we haven't executed the split yet, I added a patch to the workspace (and to the no-std-check crate) to use https://github.com/hu55a1n1/ibc-proto as a git dependency for the time being. This must be removed prior to merging.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.
  • Remove the cargo workspace (and no-std-check crate) patch git dependency

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@hu55a1n1 hu55a1n1 force-pushed the hu55a1n1/remove-proto branch from ea68b0d to 2bb2a45 Compare September 22, 2022 12:13
@hu55a1n1 hu55a1n1 mentioned this pull request Sep 22, 2022
7 tasks
@hu55a1n1 hu55a1n1 requested review from plafer and romac September 22, 2022 12:51
@hu55a1n1 hu55a1n1 marked this pull request as ready for review September 22, 2022 14:05
@hu55a1n1 hu55a1n1 force-pushed the hu55a1n1/remove-proto branch from 038027e to 70dfd05 Compare September 28, 2022 08:38
@romac romac merged commit 84b20ba into master Oct 4, 2022
@romac romac deleted the hu55a1n1/remove-proto branch October 4, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider splitting modules and other libraries into a pure library workspace repository
2 participants