-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove proto crates from the repository #2667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu55a1n1
force-pushed
the
hu55a1n1/remove-proto
branch
from
September 22, 2022 12:13
ea68b0d
to
2bb2a45
Compare
hu55a1n1
force-pushed
the
hu55a1n1/remove-proto
branch
from
September 28, 2022 08:38
038027e
to
70dfd05
Compare
romac
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #2639
Closes: #1579
Description
This PR is part of the repo-split work and deletes the proto crates (
ibc-proto
andibc-proto-compiler
) from the workspace and modifies other crates to depend on the crates.io versions of the proto crate directly. It also attempts to delete all references to the proto crates in the repository (docs, GitHub workflows, etc.).The PR additionally fixes some GitHub workflow paths that were incorrect.
Note: Since we haven't executed the split yet, I added a patch to the workspace (and to the
no-std-check
crate) to usehttps://github.com/hu55a1n1/ibc-proto
as a git dependency for the time being. This must be removed prior to merging.PR author checklist:
unclog
.Added tests: integration (for Hermes) or unit/mock tests (for modules).docs/
).no-std-check
crate) patch git dependencyReviewer checklist:
Files changed
in the GitHub PR explorer.