Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not for Merging] Add wasm contract support #2815

Closed

Conversation

colmazia
Copy link

@colmazia colmazia commented Nov 4, 2022

Not for merging, just a reference

Description

As discussed on discord, I open this pr of our version of implementing wasm contract support for hermes


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 added the E: wasm External: related to WASM and CosmWasm support label Nov 4, 2022
@seanchen1991 seanchen1991 changed the title Add wasm contract support [Not for Merging] Add wasm contract support Nov 4, 2022
@adizere
Copy link
Member

adizere commented Nov 19, 2022

FYI I gave this to a user who contacted us by email with the same problem as signalled in #2850 -- they expected to be able to relay based on events with hermes start but it wasn't working for them since their packets originated from CW contracts.

@adizere adizere linked an issue Nov 19, 2022 that may be closed by this pull request
6 tasks
@ancazamfir
Copy link
Collaborator

Could you provide a github link or code snippet from a contract that emits the event with wasm module? Also add here some context from discord? Is this is for a Cosmos chain that uses the ibc-go handlers?

@colmazia
Copy link
Author

colmazia commented Jan 9, 2023

@ancazamfir

  • the "wasm" value in the message.module key is come from wasm module not from the contract.
    But if you want some contract example, you can go look at this
  • I try to use it for BandChain which is the Cosmos chain that implement ibc-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: wasm External: related to WASM and CosmWasm support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Hermes to relay wasm messages
4 participants