Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Localchain feature #289

Closed
wants to merge 19 commits into from
Closed

WIP: Localchain feature #289

wants to merge 19 commits into from

Conversation

adizere
Copy link
Member

@adizere adizere commented Oct 6, 2020

Closes: #158 (not ready!)

Before merging:

  • This depends on tendermint-rs commit 3298d63 being released.
  • Remove the git options from the cargo's toml files and pin against a release.

For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@adizere
Copy link
Member Author

adizere commented Oct 8, 2020

This PR is currently on hold. Partly because this is blocked on tendermint-rs side, partly because fixing cosmos/ibc-rs#111 takes priority for the moment.

@adizere adizere self-assigned this Oct 8, 2020
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #289 into master will increase coverage by 23.3%.
The diff coverage is 66.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    informalsystems/hermes#289      +/-   ##
=========================================
+ Coverage    13.6%   37.0%   +23.3%     
=========================================
  Files          69     129      +60     
  Lines        3752    8390    +4638     
  Branches     1374    2905    +1531     
=========================================
+ Hits          513    3106    +2593     
- Misses       2618    5105    +2487     
+ Partials      621     179     -442     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 13.6% <0.0%> (-19.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/packet.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/client_def.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/error.rs 75.0% <ø> (+75.0%) ⬆️
modules/src/ics18_relayer/error.rs 0.0% <0.0%> (ø)
modules/src/ics26_routing/error.rs 75.0% <0.0%> (ø)
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbefaa...2a39c57. Read the comment docs.

@adizere
Copy link
Member Author

adizere commented Nov 10, 2020

We're abandoning this PR in favor of two smaller ones. We'll have one PR that focuses exclusively on modifications for the ibc crate (#390), plus another PR where we'll add the localchain feature itself (mostly modifications in the relayer and cli crates).

@adizere adizere closed this Nov 10, 2020
@adizere adizere deleted the adi/158_localchain branch November 10, 2020 10:37
adizere added a commit that referenced this pull request Nov 19, 2020
* Bringing changes from the older PR #289, first pass.

* Second pass

* Third pass done, finished bringing old changes.

* Updated changelog

* Removed useless test conditional compilation.

* Clippy exceptions to disable dead code warning

* Removing dep on the dev branch

* Update tendermint-testgen dependency

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Prep context to store multiple types of clients. Deleted mock error.

* Moved module mock_client into mock

* Generalized MockClientRecord

* with_client_parametrized done

* Added basic implementation for TM::check_header_and_update_state.

* Apply suggestions from code review

Applied Anca's comments

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Bringing changes from the older PR informalsystems#289, first pass.

* Second pass

* Third pass done, finished bringing old changes.

* Updated changelog

* Removed useless test conditional compilation.

* Clippy exceptions to disable dead code warning

* Removing dep on the dev branch

* Update tendermint-testgen dependency

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Prep context to store multiple types of clients. Deleted mock error.

* Moved module mock_client into mock

* Generalized MockClientRecord

* with_client_parametrized done

* Added basic implementation for TM::check_header_and_update_state.

* Apply suggestions from code review

Applied Anca's comments

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local chain type
2 participants