-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the default trust threshold for new clients to 2/3 #2988
Conversation
Context: See the recommendation following the work by Tendermint team: tendermint/tendermint#9420
73032aa
to
b342f6e
Compare
Signed-off-by: Romain Ruetschi <romain@informal.systems>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @romac !
I wrote a little tool to fetch the latest 1000 blocks from the Cosmos Hub with a step of 1, 5, and 10 and compute the voting power overlap between all adjacent blocks. The results are here (there are multiple files each with a different step). I did not see an overlap less than 2/3 so I would assume that the impact of this change in terms of client updates will be low if not null, at least on the Hub. Will check with other chains with smaller validator sets. |
Ran some tests on Chihuahua, Evmos, Injective, and Secret and did not find a validator set change greater than 1/3 over any combination of the past 1000 blocks. Let's merge this :) |
Closes: #2876
Description
Note that the default trust threshold used for creating a client with
create client
when no trust threshold is specified on the command line is taken from the chain config'strust_threshold
setting. We should therefore advise operators to update their configs with the new recommended value as otherwise the changes below won't have any effect outside of tests.PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.