Avoid unwrap() for Height conversion #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #300
This fixes most of the
try_into().unwrap()
around Height type conversion. The unwraps were recently necessary for a quick alignment with tendermint-rs changes in Height type.Several uses of
try_into().unwrap()
still exist in our code in places where it was difficult to fix (some in relayer-cli) or places which are currently in flux (context mocks, which will be removed soon).Description
For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer