Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll the chain for new blocks instead of using the WebSocket #3209

Closed
wants to merge 22 commits into from
Closed

Poll the chain for new blocks instead of using the WebSocket #3209

wants to merge 22 commits into from

Conversation

romac
Copy link
Member

@romac romac commented Mar 31, 2023 •
edited
Loading

Closes: #3190
Closes: #2809
Closes: #2850

Might address: #3206 (see also #1299)

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac changed the title Refactor the event monitor to poll the chain for new blocks instead of using the WebSocket Poll the chain for new blocks instead of using the WebSocket Mar 31, 2023
@romac romac changed the base branch from master to romac/message-event March 31, 2023 13:52
@romac romac mentioned this pull request Apr 4, 2023
Closed
7 tasks
@romac
Copy link
Member Author

romac commented Apr 14, 2023

This seems to have made the tests slower (~32min vs 26min previously). I will look into that.

@romac romac mentioned this pull request Apr 17, 2023
Closed
12 tasks
@seanchen1991 seanchen1991 linked an issue Apr 17, 2023 that may be closed by this pull request
Remove dependency on "message" events #3190
Closed
5 tasks
This was linked to issues Apr 17, 2023
Allow Hermes to relay wasm messages #2809
Closed
Hermes relaying modes: push versus pull relaying #2850
Closed
@romac romac deleted the branch master April 26, 2023 15:22
@romac romac closed this Apr 26, 2023
@romac romac reopened this Apr 26, 2023
@romac romac changed the base branch from romac/message-event to master April 26, 2023 15:24
@romac
Copy link
Member Author

romac commented May 9, 2023

Superseded by #3323

@romac romac closed this May 9, 2023
@romac romac deleted the romac/poll-block-results branch November 22, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@romac