Detect light client attacks and report them to both the chain and the RPC node #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
force-pushed
the
romac/attack-detector
branch
from
dd44561 to
2893270
Compare
romac
force-pushed
the
romac/attack-detector
branch
from
2893270 to
f7093e8
Compare
ancazamfir
requested changes
Apr 14, 2023
There was a problem hiding this comment.
Great work @romac!!! Did a fist pass in parallel with the tendermint-rs changes.
…but omit them from minimal set
romac
commented
Apr 26, 2023
romac
commented
Apr 26, 2023
romac
commented
Apr 26, 2023
romac
commented
Apr 26, 2023
Signed-off-by: Romain Ruetschi <romain@informal.systems>
Signed-off-by: Romain Ruetschi <romain@informal.systems>
pratikbin
pushed a commit
to pratikbin/hermes
that referenced
this pull request
May 24, 2023
… RPC node (informalsystems#3224) * Prepare for generating light client attacks * Remove redundant message * Improve script * Use tendermint-rs with new misbehavior detector * Small refactor in client worker * Cleanup and notes in ForeignClient * Some more cleanup * Call to the new attack detector * Build evidence to report to the chain * Fix client updates * It's working, I think * Move create_fork.sh to scripts folder * Use tendermint-rs branch * Use new light client detector crate * Remove explicit dependency on `tendermint-light-client-verifier` * Update to latest detector * Add integration test for misbehavior detection * Fix clippy warnings * Print Hermes logs * Update to latest detector * Update to latest detector * Remove unused `headers_compatible` * Remove unused import * Get current time from chain's sync status * Compute proper supporting headers * Infallible height conversions * Refactor to include trusted and target headers in supporting headers but omit them from minimal set * Always omit target header from supporting set * Use trusted height and not height of last supporting header * Use target header of new round of verification to get trusted height and validators * Update tendermint-rs to v0.31.1 * Update `ibc-proto` to v0.30.0 * Compilation fixes after detector update * Use witness trace computed by the detector instead of verifying again (informalsystems#3277) * Fix merge issues * Update to latest detector * Ensure trusted validator set matches the fetched one * Update to latest detector * Update to tendermint-rs v0.32.0 and `ibc-proto` v0.31.0-alpha.2 * Add changelog entry --------- Signed-off-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2772
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.