Improved tests for 'hermes config auto' #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljoss17
added
I: CLI
seanchen1991
approved these changes
May 1, 2023
There was a problem hiding this comment.
Some minor nits, but otherwise looks good. Thanks @ljoss17!
| use ibc_chain_registry::querier::{ | ||
| GrpcHealthCheckQuerier, HermesConfigData, QueryContext, SimpleHermesRpcQuerier, | ||
| }; | ||
| use ibc_relayer::config::{ |
There was a problem hiding this comment.
I'm thinking we don't want to have import statements nest more than one level deep; it makes it harder search and parse what's being imported. Could we split these out into multiple use statements?
| @@ -245,16 +285,26 @@ pub async fn get_configs( | |||
| get_data_from_handles::<ChainConfig>(config_handles, "config_handle_join").await | |||
| } | |||
|
|
|||
| /// Concurrent RPC and GRPC queries are likely to fail. | |||
| /// Since the the RPC and GRPC endpoints are queried to confirm they are healthy, | |||
There was a problem hiding this comment.
Suggested change
| /// Since the the RPC and GRPC endpoints are queried to confirm they are healthy, | |
| /// Since the RPC and GRPC endpoints are queried to confirm they are healthy, |
pratikbin
pushed a commit
to pratikbin/hermes
that referenced
this pull request
May 24, 2023
* Improved tests in 'chain_registry' * Fix typo * Improve 'query_healthy_retry' method * Applied PR suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3282
Description
This PR has two main improvements:
query_healthyfunction a fixed number of times to avoid errors due to having too many concurrent queries.Some additional comments have been added to clarify sensible parts of the code.
PR author checklist:
Added changelog entry, usingunclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.