Add destination chain to confirmed packet metrics #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have easy access to the dst channel and port ids? If so let's add them to the labels as well |
|
I'll check this and update if possible |
seanchen1991
approved these changes
May 3, 2023
I was able to add them in this commit 3b3213e. What do you think about this ? |
romac
approved these changes
May 16, 2023
romac
pushed a commit
that referenced
this pull request
May 16, 2023
* Add destination chain to confirmed packet metrics * Add changelog entry * Update guide example of telemetry output * Add destination channel and port to confirmed receive, ack and timeout packets
pratikbin
pushed a commit
to pratikbin/hermes
that referenced
this pull request
May 24, 2023
* Add destination chain to confirmed packet metrics * Add changelog entry * Update guide example of telemetry output * Add destination channel and port to confirmed receive, ack and timeout packets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3297
Description
PR author checklist:
unclog.Added tests: integration (for Hermes) or unit/mock tests (for modules).docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.