Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish multi-platform (arm64/amd64) images to Docker Hub and GHCR #3305

Merged
merged 3 commits into from
May 8, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 6, 2023

Closes: #3303

Description

This PR changes release.yml so that multiplatform images are simultaneously
pushed to docker hub and to ghcr.io. This reduces cost, increases control and
visibility while making hermes easier to work with.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@faddat
Copy link
Contributor Author

faddat commented May 6, 2023

Signed-off-by: Romain Ruetschi <romain.ruetschi@gmail.com>
@romac romac changed the title use ghcr Publish multi-platform (arm64/amd64) images to Docker Hub and GHCR May 8, 2023
@romac
Copy link
Member

romac commented May 8, 2023

@faddat Thanks for taking care of this!

@romac romac merged commit 7f6e9f7 into informalsystems:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish multi-platform (arm64/amd64) images on Docker Hub and GHCR
2 participants