Allow disabling header verification by setting trusted_node = true in the chain config
#3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancazamfir
approved these changes
May 19, 2023
config.toml
Outdated
Comment on lines
135
to
138
| # Enable verification of headers including in `ClientUpdate` message using the light client. | ||
| # Default: true | ||
| verify_headers = true | ||
|
|
There was a problem hiding this comment.
Maybe mention this is experimental. Also maybe:
Suggested change
| # Enable verification of headers including in `ClientUpdate` message using the light client. | |
| # Default: true | |
| verify_headers = true | |
| # Whether or not the full node is trusted. | |
| # If not trusted it enables verification of headers including in `ClientUpdate` message using the light client. | |
| # Note: If the full node is configured as trusted then in addition to headers not being verified, the verification traces will not be provided. This may cause failure in client updates after significant change in validator sets. | |
| # Default: false | |
| trusted_node = false | |
romac
changed the title
verify_header chain settingtrusted_node = true in the chain config
ancazamfir
approved these changes
May 22, 2023
pratikbin
pushed a commit
to pratikbin/hermes
that referenced
this pull request
May 24, 2023
…in the chain config (informalsystems#3328) * Disable verification of headers, and therefore generation of traces * Add `verify_headers` setting to the chain config * Cleanup * Add changelog entry * Rename `verify_headers` to `trusted_node` * Update changelog entry --------- Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3330
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.