Output profiling data as JSON, with additional metadata #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial version to store profiling in file * Open profiling file only on start * Use OnceCell instead of RefCell * Update tracing from info to trace for profiling * Revert "Update tracing from info to trace for profiling" This reverts commit 5c9117a4daa83664a562f0bdbcb135996586c910.
ljoss17
approved these changes
May 15, 2023
|
Yes they are too noisy and are not actually bottlenecks. |
pratikbin
pushed a commit
to pratikbin/hermes
that referenced
this pull request
May 24, 2023
…ems#3329) * Add time calls * Instrument event monitor * Profiling to json * Initial version to store profiling in file * Open profiling file only on start * Use OnceCell instead of RefCell * Update tracing from info to trace for profiling * Revert "Update tracing from info to trace for profiling" This reverts commit 5c9117a4daa83664a562f0bdbcb135996586c910. * Use HHMMSS in profile file name * Pad numbers * Add profiling for wait time in 'wait_and_build_update_client_with_trusted' * Add chain_id to profiling data * Turn warnings to debug * Add changelog entry --------- Co-authored-by: Sean Chen <skypemaster007@gmail.com> Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3332
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.