Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migaloo ics29 tests #3346

Merged
merged 3 commits into from
May 18, 2023
Merged

Add migaloo ics29 tests #3346

merged 3 commits into from
May 18, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented May 17, 2023

Closes: #3345

Description

This PR adds migaloo chain to the chains used in the ics29 tests.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added O: ics29-fee Objective: Fee middleware support O: testability Objective: cause to provide more testing tools and extensions labels May 17, 2023
@ljoss17 ljoss17 requested a review from romac May 17, 2023 08:03
@romac romac merged commit 9cacc93 into master May 18, 2023
@romac romac deleted the luca_joss/add-migaloo-ics29-tests branch May 18, 2023 11:40
pratikbin pushed a commit to pratikbin/hermes that referenced this pull request May 24, 2023
* Add migaloo chain to ics29 tests

* Add changelog entry

* Update nix flake after migaloo fix in Cosmos Nix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: ics29-fee Objective: Fee middleware support O: testability Objective: cause to provide more testing tools and extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add White Whale migaloo chain to ICS29 tests
2 participants