Integrate relayer spike into relayer crate #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Implement the proper pipeline of types from IBCEvent to Packet to
Transactions etc.
+ Move client updates to be bundled in transactions
+ The system model for IBC requires that a correct relayer persist
in trying to submit packets even with semantic failures.
+ Implement a sketch of retry logic
+ TODO: Add proper error handling
+ Introduce a Failed link error to signal to a future supervisor
process that a link needs to be re-established with a different full
node.
ancazamfir
approved these changes
Oct 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
=========================================
+ Coverage 13.6% 36.5% +22.8%
=========================================
Files 69 127 +58
Lines 3752 8168 +4416
Branches 1374 2827 +1453
=========================================
+ Hits 513 2986 +2473
- Misses 2618 5009 +2391
+ Partials 621 173 -448
Continue to review full report at Codecov.
|
Closed
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Incomplete Pseudo code which compiles
* commit notes and sketches from first sync
* It compiles but still very rough
* Introduce ForeignClient
* Move update client to ForeignClient
* Introduce ChainRuntime
* Introduce subscriptions
* Type alias
* Introduce Chain as a trait ^_^
* Re-add update_client logic
* update notes
* Silence warnings for now
* Add error handling
* Fixup sequences of dependencies
* move client updates to ForeignClient
* Significant progress:
+ Implement the proper pipeline of types from IBCEvent to Packet to
Transactions etc.
+ Move client updates to be bundled in transactions
* Add error handling for packet creation
* Implement submission retry:
+ The system model for IBC requires that a correct relayer persist
in trying to submit packets even with semantic failures.
+ Implement a sketch of retry logic
+ TODO: Add proper error handling
* Attempt to add proper error handling to retry loop
* Bugfix: ClientUpdate should be attempt specific
* LinkError:Failed
+ Introduce a Failed link error to signal to a future supervisor
process that a link needs to be re-established with a different full
node.
* Make chains private to links
* Document intentions
* Integrate relayer spike into relayer crate
* Remove comment in workspace Cargo.toml
* Move spike main function into v0 command
* Update changelog
Co-authored-by: Sean Braithwaite <brapse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on #210 (and supersedes it) and integrate the relayer spike into the relayer crate.
For now, only minimal changes have been made to the original code, just what was needed to depend on the actual
tendermintandibctypes + clippy lints.Additionally, a new
v0command has been added, which contains the code of the spike's main function.Also, the relayer-spike README has been moved to the
docs/architecturefolder.For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer