Handle duplicate packet events and perform full clearing even in the presence of errors #3361
Conversation
…d only retain the event from the highest one with fully matches the criteria
…d timeout packets failed
| if let Some(event) = packet_from_tx_search_response(chain_id, request, *seq, tx)? { | ||
| // We found the event | ||
| result.push(event); | ||
| break 'inner; |
There was a problem hiding this comment.
Instead of breaking, could we get them all, if more than 1 extracted print a warning with some tx hashes or height info? And then pick the first? In 99.99% of cases there will be only one so there is no perf impact. But it would give very valuable feedback to the user
|
Looks good. I tried it on the testnet and output looks as good as it can get. I don't have wallets so the actual transactions are not sent so not sure about the fix for |
| let (first_event, _, _) = tx_events.remove(0); | ||
| result.push(first_event); |
There was a problem hiding this comment.
can we pull these out of the if as we do it for both branches
romac
changed the title
There was a problem hiding this comment.
Looks great! Packets are cleared on the testnet! Thanks @romac !!
|
Thank you for diagnosing the issue and coming up with a way to fix it 🙏 |
Closes: #3359
Closes: #3358
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.