Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tendermint-rs 0.33.0 and adapt to RPC changes in CometBFT 0.38 #3372

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Update to tendermint-rs 0.33.0 and adapt to RPC changes in CometBFT 0.38 #3372

merged 7 commits into from
Aug 21, 2023

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented May 26, 2023 •
edited by romac
Loading

Closes: #3548
Requires: informalsystems/tendermint-rs#1317

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@mzabaluev mzabaluev force-pushed the mikhail/cometbft-0.38 branch from 14ae073 to 0c77517 Compare May 29, 2023 15:22
@mzabaluev mzabaluev mentioned this pull request Jun 1, 2023
Merged
5 tasks
@mzabaluev mzabaluev force-pushed the mikhail/cometbft-0.38 branch from 0c77517 to dd61ff4 Compare June 12, 2023 14:44
@mzabaluev mzabaluev force-pushed the mikhail/cometbft-0.38 branch from dd61ff4 to 7181104 Compare August 10, 2023 14:20
@mzabaluev mzabaluev force-pushed the mikhail/cometbft-0.38 branch from b4dcb47 to 71b066e Compare August 17, 2023 12:40
@mzabaluev mzabaluev marked this pull request as ready for review August 17, 2023 12:59
@mzabaluev mzabaluev requested a review from romac August 17, 2023 13:00
romac
romac reviewed Aug 21, 2023
View reviewed changes
crates/relayer-types/Cargo.toml Outdated Show resolved Hide resolved
tools/query-events/src/main.rs Show resolved Hide resolved
@romac romac changed the title Adapt to RPC changes in CometBFT 0.38 Update to tendermint-rs 0.33.0 and adapt to RPC changes in CometBFT 0.38 Aug 21, 2023
@romac romac merged commit 9646762 into master Aug 21, 2023
@romac romac deleted the mikhail/cometbft-0.38 branch August 21, 2023 09:03
@romac
Copy link
Member

romac commented Aug 21, 2023

Thanks a lot for this @mzabaluev 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tendermint-rs to v0.33.x and adapt to RPC changes in CometBFT 0.38
2 participants
@mzabaluev @romac