Configurable range for histogram buckets for latency metrics #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljoss17
commented
May 31, 2023
crates/telemetry/src/state.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug)] | ||
| struct CustomAggregatorSelector; |
There was a problem hiding this comment.
Should we remove the previous aggregator selector ?
ljoss17
commented
May 31, 2023
crates/telemetry/src/state.rs
Outdated
| } | ||
|
|
||
| pub fn get_submitted_range(&self) -> Vec<f64> { | ||
| let step = (self.tx_latency_submitted_max - self.tx_latency_submitted_min) / 10; |
There was a problem hiding this comment.
Do we want the number of buckets to be configurable also ?
romac
reviewed
May 31, 2023
romac
reviewed
May 31, 2023
ancazamfir
reviewed
Jun 5, 2023
…and confirmed latencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3366
Description
This PR adds 2 new configurations:
submitted_rangeused to specify the range of the histogrambuckets for the
tx_latency_submittedmetric.confirmed_rangeused to specify the range of the histogrambuckets for the
tx_latency_confirmedmetric.Allowing the buckets to be changed without the need to recompile Hermes
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.