Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code #3383

Merged
merged 7 commits into from
Jun 5, 2023
Merged

Clean code #3383

merged 7 commits into from
Jun 5, 2023

Conversation

DaviRain-Su
Copy link
Contributor

Closes: #XXX

Description

Since the IBC module has been spun off and the ibc-relayer-type crate is only used in Hermes and nowhere else, we can remove all no-std related content and default-features = false.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac
Copy link
Member

romac commented May 31, 2023

Thank you for this! Can you please just undo the modifications to the dependencies? Removing the default features on all these crates adds a lot of dependencies which we don't actually need.

Otherwise it looks great!

crates/relayer-types/Cargo.toml Outdated Show resolved Hide resolved
crates/relayer-types/Cargo.toml Outdated Show resolved Hide resolved
romac and others added 3 commits June 5, 2023 10:14
@romac romac merged commit ae0a00b into informalsystems:master Jun 5, 2023
@DaviRain-Su DaviRain-Su deleted the clean-code branch June 6, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants